On Fri, Dec 31, 2010 at 11:03 AM, Senaka Fernando <[email protected]> wrote: > Hi Pradeeban, > > On Fri, Dec 31, 2010 at 3:17 AM, Kathiravelu Pradeeban <[email protected]> > wrote: >> >> Hi Senaka, >> I was fixing two usability related issues of Stratos-1.0.0. >> 1) Making the email validation optional based on a configuration file >> input. [STRATOS-848] >> 2) Modifying the password reset feature, such that user gives his own >> password, (instead of getting the reset password by email, he gets a >> link to reset it himself.) [STRATOS-835] >> >> I fixed these in both trunk and the branch. As I got, these should be >> fixed for 1.0.0 too, such that we can have the above mentioned 2 >> issues fixed. > > Question is not on the code that was committed (I agree that they are > proper) but on where the code was committed. According to our branching > strategy, when one version of a module has been released (which is what > happened with Stratos 1.0.0, I suppose), the next would be 1.0.1. The reason > is that we can't have two different 1.0.0 bundles.
I understand. In case of the new component/feature admin-mgt I introduced to the carbon, I used the version 3.1.1 instead of 3.1.0, which has been released already. I was under the impression that except for the new components/modules, we should fix for the latest version which has been released already (as well as the trunk). Thanks for the explanation. Will do the necessary changes/moves by this Monday. Regards, Pradeeban. > > Thanks, > Senaka. >> >> This cosmetic fix fixes a minor issue that is introduced in the >> related commit, I guess. >> >> Pls correct me, if I got it wrong. >> >> Thank you. >> Regards, >> Pradeeban. >> >> On Fri, Dec 31, 2010 at 2:52 AM, Senaka Fernando <[email protected]> wrote: >> > Hi Pradeeban, >> > >> > These kinds of changes should be done to the 1.0.1 version of this >> > component >> > isn't it? 1.0.0 has already been released with the last Stratos GA, and >> > thus >> > can't be modified, according to my understanding. Did I get it wrong? >> > >> > Thanks, >> > Senaka. >> > >> > On Fri, Dec 31, 2010 at 2:06 AM, <[email protected]> wrote: >> >> >> >> Author: pradeeban >> >> Date: Thu Dec 30 12:36:55 2010 >> >> New Revision: 84677 >> >> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=84677 >> >> >> >> Log: >> >> Cosmetic fix - moving a commented skip-link upward towards the >> >> associated >> >> links. >> >> >> >> >> >> Modified: >> >> >> >> >> >> branches/stratos/1.0.0/stratos/components/account-mgt/org.wso2.stratos.account.mgt.ui/1.0.0/src/main/resources/META-INF/component.xml >> >> >> >> Modified: >> >> >> >> branches/stratos/1.0.0/stratos/components/account-mgt/org.wso2.stratos.account.mgt.ui/1.0.0/src/main/resources/META-INF/component.xml >> >> URL: >> >> >> >> http://wso2.org/svn/browse/wso2/branches/stratos/1.0.0/stratos/components/account-mgt/org.wso2.stratos.account.mgt.ui/1.0.0/src/main/resources/META-INF/component.xml?rev=84677&r1=84676&r2=84677&view=diff >> >> >> >> >> >> ============================================================================== >> >> --- >> >> >> >> branches/stratos/1.0.0/stratos/components/account-mgt/org.wso2.stratos.account.mgt.ui/1.0.0/src/main/resources/META-INF/component.xml >> >> (original) >> >> +++ >> >> >> >> branches/stratos/1.0.0/stratos/components/account-mgt/org.wso2.stratos.account.mgt.ui/1.0.0/src/main/resources/META-INF/component.xml >> >> Thu Dec 30 12:36:55 2010 >> >> @@ -33,9 +33,9 @@ >> >> <skip-authentication> >> >> >> >> <skip-link>../account-mgt/update_profile_processor.jsp</skip-link> >> >> >> >> <!--<skip-link>../account-mgt/update_verifier.jsp</skip-link>--> >> >> + >> >> >> >> <!--<skip-link>../account-mgt/update_verifier_redirector_ajaxprocessor.jsp</skip-link>--> >> >> >> >> >> >> <!--<skip-link>../email-verification/validator_ajaxprocessor.jsp</skip-link>--> >> >> >> >> <!--<skip-link>../email-verification/invalid_email.jsp</skip-link>--> >> >> - >> >> >> >> <!--<skip-link>../account-mgt/update_verifier_redirector_ajaxprocessor.jsp</skip-link>--> >> >> </skip-authentication> >> >> </menu> >> >> </menus> >> >> _______________________________________________ >> >> Carbon-commits mailing list >> >> [email protected] >> >> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits >> > >> > >> > >> > -- >> > Senaka Fernando >> > Associate Technical Lead & Product Manager - WSO2 G-Reg; >> > WSO2, Inc.; http://wso2.com >> > Member; Apache Software Foundation; http://apache.org >> > >> > E-mail: senaka AT wso2.com >> > P: +1 408 754 7388; ext: 51736; M: +94 77 322 1818 >> > Linked-In: http://www.linkedin.com/in/senakafernando >> > >> > Lean . Enterprise . Middleware >> > >> > >> >> >> >> -- >> Kathiravelu Pradeeban. >> Software Engineer. >> WSO2 Inc. >> >> Blog: [Llovizna] http://kkpradeeban.blogspot.com/ > > > > -- > Senaka Fernando > Associate Technical Lead & Product Manager - WSO2 G-Reg; > WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://apache.org > > E-mail: senaka AT wso2.com > P: +1 408 754 7388; ext: 51736; M: +94 77 322 1818 > Linked-In: http://www.linkedin.com/in/senakafernando > > Lean . Enterprise . Middleware > > -- Kathiravelu Pradeeban. Software Engineer. WSO2 Inc. Blog: [Llovizna] http://kkpradeeban.blogspot.com/ _______________________________________________ Carbon-dev mailing list [email protected] https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
