Here are the notes taken during the review. *org.wso2.carbon.dataservices.core.description.query.Query*
1. For consistency instantiate Exception by passing message first and then the exception in the constructor. * org.wso2.carbon.dataservices.common.DBConstants* 1. Inner class XSDTypes is duplicating constants defined elsewhere inside the class. 2. Ideally DBConstants should be renamed to reflect these are data service constants. * In general improve the documentation on usage of constants. In line comments can be found in Crucible project at https://wso2.org/crucible/cru/COMPONENT-22 On Thu, Jan 20, 2011 at 2:11 AM, Senaka Fernando <[email protected]> wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=OHQ0cW10cGUycGJ2Y2d1bjNmdDh1YTg1bXMgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTUjc2VuYWthQHdzbzIuY29tYzJlZGNiZWZlYWU1ODY0MjI1MGM2MjdlNGQxNzZjMWRiMTllMmE5Mg&ctz=Asia%2FColombo&hl=en> > [Group E] Code Review > This week's code review session for group E will be held in #59. We will be > reviewing the RDF implementation in DSS and Amani will own this code review > session. > *When* > Thu Jan 20 10:30am – 11:30am Colombo > *Where* > #59 board room (map <http://maps.google.com/maps?q=%2359+board+room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Senaka Fernando - organizer > • > Hiranya Jayathilaka > • > Amani Soysa > • > [email protected] > • > Sumedha Rubasinghe > • > Anjana Fernando > > Going? > *Yes<https://www.google.com/calendar/event?action=RESPOND&eid=OHQ0cW10cGUycGJ2Y2d1bjNmdDh1YTg1bXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=1&tok=MTUjc2VuYWthQHdzbzIuY29tYzJlZGNiZWZlYWU1ODY0MjI1MGM2MjdlNGQxNzZjMWRiMTllMmE5Mg&ctz=Asia%2FColombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=OHQ0cW10cGUycGJ2Y2d1bjNmdDh1YTg1bXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=3&tok=MTUjc2VuYWthQHdzbzIuY29tYzJlZGNiZWZlYWU1ODY0MjI1MGM2MjdlNGQxNzZjMWRiMTllMmE5Mg&ctz=Asia%2FColombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=OHQ0cW10cGUycGJ2Y2d1bjNmdDh1YTg1bXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=2&tok=MTUjc2VuYWthQHdzbzIuY29tYzJlZGNiZWZlYWU1ODY0MjI1MGM2MjdlNGQxNzZjMWRiMTllMmE5Mg&ctz=Asia%2FColombo&hl=en> > * more options > »<https://www.google.com/calendar/event?action=VIEW&eid=OHQ0cW10cGUycGJ2Y2d1bjNmdDh1YTg1bXMgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTUjc2VuYWthQHdzbzIuY29tYzJlZGNiZWZlYWU1ODY0MjI1MGM2MjdlNGQxNzZjMWRiMTllMmE5Mg&ctz=Asia%2FColombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this courtesy email at the account > [email protected] you are an attendee of this event. > > To stop receiving future notifications for this event, decline this event. > Alternatively you can sign up for a Google account at > https://www.google.com/calendar/ and control your notification settings > for your entire calendar. > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Buddhika Chamith Software Engineer WSO2 Inc. (+94716386418) http://wso2.com http://chamibuddhika.wordpress.com
_______________________________________________ Carbon-dev mailing list [email protected] https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
