Code Review Notes =============== Participants : Nuwan, Milinda, Nandika, Lahiru, Manjula, Sarasi, Lalaji, ChamaraA, Dinithi, Heshan
DashBoardUiServcieComponent.java ------------------------------------------------------- Isolate the one method and have several private methods to access it. Have minimum amount of code within a single method. Have a generic method to take in parameters which will call a specific method to call them. index.jsp ------------- Look into whether operational level authentication can be done here. try to seperate out scripts into several parts and have them in a seperate files. Then include them in this. DashboardService.java ----------------------------------- Use a template generator method to generate the layout. Use a ENUM to create the twoColumn layout. Remove printStackTraces() and throw an Exception. General Observations ------------------------------- Load the stuff asynchronously. Only load the necessary parts first. Load others when they are needed. Code level comments will be added to the crucible project. On Tue, Jan 25, 2011 at 3:30 PM, Nuwan Bandara <[email protected]> wrote: > This event has been changed. > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=cWR1M3U2Z2k0aXJ1aXZuM3RoYnBkYWs3YWcgaGVzaGFuQHdzbzIuY29t&tok=MTQjbnV3YW5Ad3NvMi5jb21iNTFlMDczNmYzNTU1ZjBhMDFkNWI3MTNlZGFmZTg1Mzg3MWE1YjNm&ctz=Asia%2FColombo&hl=en> > Group B - Code Review > *Changed: *The Code review will cover the re-factored Dashboard Service. | > https://wso2.org/crucible/cru/COMPONENT-25<http://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FCOMPONENT-25&ust=1295956835231000&usg=AFQjCNGtxzynpm2UwIeSmAXHdri07ur0Ug> > *When* > Fri Jan 28 10am – 11am Colombo > *Where* > 3rd Floor Conference Room > (map<http://maps.google.com/maps?q=3rd+Floor+Conference+Room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > [email protected] - organizer > • > Chamara Ariyarathne > • > Milinda Pathirage > • > Manjula Rathnayake > • > Lahiru Gunathilake > • > Amal Rangana > • > Chamara Silva > • > [email protected] > • > Krishantha Samaraweera > • > Sanjeewa Malalgoda > • > Ruwan Linton > • > Sumedha Rubasinghe > • > Saminda Wijeratne > • > Heshan Suriyaarachchi > • > Nandika Jayawardana > • > Sarasi Munasinghe > • > Ajith Vitharana > > Going? > *Yes<https://www.google.com/calendar/event?action=RESPOND&eid=cWR1M3U2Z2k0aXJ1aXZuM3RoYnBkYWs3YWcgaGVzaGFuQHdzbzIuY29t&rst=1&tok=MTQjbnV3YW5Ad3NvMi5jb21iNTFlMDczNmYzNTU1ZjBhMDFkNWI3MTNlZGFmZTg1Mzg3MWE1YjNm&ctz=Asia%2FColombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=cWR1M3U2Z2k0aXJ1aXZuM3RoYnBkYWs3YWcgaGVzaGFuQHdzbzIuY29t&rst=3&tok=MTQjbnV3YW5Ad3NvMi5jb21iNTFlMDczNmYzNTU1ZjBhMDFkNWI3MTNlZGFmZTg1Mzg3MWE1YjNm&ctz=Asia%2FColombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=cWR1M3U2Z2k0aXJ1aXZuM3RoYnBkYWs3YWcgaGVzaGFuQHdzbzIuY29t&rst=2&tok=MTQjbnV3YW5Ad3NvMi5jb21iNTFlMDczNmYzNTU1ZjBhMDFkNWI3MTNlZGFmZTg1Mzg3MWE1YjNm&ctz=Asia%2FColombo&hl=en> > * more options > »<https://www.google.com/calendar/event?action=VIEW&eid=cWR1M3U2Z2k0aXJ1aXZuM3RoYnBkYWs3YWcgaGVzaGFuQHdzbzIuY29t&tok=MTQjbnV3YW5Ad3NvMi5jb21iNTFlMDczNmYzNTU1ZjBhMDFkNWI3MTNlZGFmZTg1Mzg3MWE1YjNm&ctz=Asia%2FColombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for updated invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings for > this calendar. > -- Regards, Heshan Suriyaarachchi Software Engineer WSO2 Inc.; http://wso2.com/ Blog: http://heshans.blogspot.com/
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
