Aha Denis, you have not been paying attention at code review sessions nor have read the Carbon best practices guide. We have repeatedly mentioned that most of the classes should be within internal packages since those have no use outside the bundle, and should not be used outside the bundle.
Azeez On Wed, Feb 16, 2011 at 9:25 AM, Denis Weerasiri <[email protected]> wrote: > > > On Wed, Feb 16, 2011 at 7:32 AM, Senaka Fernando <[email protected]> wrote: > >> >> >> On Wed, Feb 16, 2011 at 3:14 AM, WSO2 Builder <[email protected]> wrote: >> >>> [INFO] task-segment: [clean, install] >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] [clean:clean] >>> [INFO] Deleting directory >>> /home/carbon/stratos/carbon/components/identity/org.wso2.carbon.identity.sts/target >>> [INFO] [resources:resources] >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>> [INFO] Copying 1 resource >>> Downloading: >>> http://dist.wso2.org/snapshots/maven2/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] snapshot org.wso2.carbon:org.wso2.carbon.xfer:3.2.0-SNAPSHOT: >>> checking for updates from wso2-maven2-snapshot-repository >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> wso2-maven2-snapshot-repository (http://dist.wso2.org/snapshots/maven2) >>> Downloading: >>> http://repository.springsource.com/maven/bundles/release/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] snapshot org.wso2.carbon:org.wso2.carbon.xfer:3.2.0-SNAPSHOT: >>> checking for updates from com.springsource.repository.bundles.release >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> com.springsource.repository.bundles.release ( >>> http://repository.springsource.com/maven/bundles/release) >>> Downloading: >>> http://repository.springsource.com/maven/bundles/external/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] snapshot org.wso2.carbon:org.wso2.carbon.xfer:3.2.0-SNAPSHOT: >>> checking for updates from com.springsource.repository.bundles.external >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> com.springsource.repository.bundles.external ( >>> http://repository.springsource.com/maven/bundles/external) >>> Downloading: >>> https://oss.sonatype.org/content/repositories/openid4java-snapshots/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] snapshot >>> org.wso2.carbon:org.wso2.carbon.identity.provider:3.2.0-SNAPSHOT: checking >>> for updates from wso2-maven2-snapshot-repository >>> [INFO] snapshot >>> org.wso2.carbon:org.wso2.carbon.identity.provider:3.2.0-SNAPSHOT: checking >>> for updates from com.springsource.repository.bundles.release >>> [INFO] snapshot >>> org.wso2.carbon:org.wso2.carbon.identity.provider:3.2.0-SNAPSHOT: checking >>> for updates from com.springsource.repository.bundles.external >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> openid4java snapshots repository ( >>> https://oss.sonatype.org/content/repositories/openid4java-snapshots) >>> Downloading: >>> http://dist.wso2.org/snapshots/maven2/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> wso2-maven2-snapshot-repository (http://dist.wso2.org/snapshots/maven2) >>> Downloading: >>> http://repository.springsource.com/maven/bundles/release/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> com.springsource.repository.bundles.release ( >>> http://repository.springsource.com/maven/bundles/release) >>> Downloading: >>> http://repository.springsource.com/maven/bundles/external/org/openid4java/openid4java-nodeps/0.9.6-SNAPSHOT/openid4java-nodeps-0.9.6-SNAPSHOT.jar >>> [INFO] Unable to find resource >>> 'org.openid4java:openid4java-nodeps:jar:0.9.6-SNAPSHOT' in repository >>> com.springsource.repository.bundles.external ( >>> http://repository.springsource.com/maven/bundles/external) >>> [INFO] [compiler:compile] >>> [INFO] Compiling 7 source files to >>> /home/carbon/stratos/carbon/components/identity/org.wso2.carbon.identity.sts/target/classes >>> [INFO] >>> ------------------------------------------------------------------------ >>> [ERROR] BUILD FAILURE >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] Compilation failure >>> /home/carbon/stratos/carbon/components/identity/org.wso2.carbon.identity.sts/src/main/java/org/wso2/carbon/identity/sts/internal/IdentitySTSServiceComponent.java:[22,40] >>> package org.wso2.carbon.user.mgt.internal does not exist >>> >> >> Huh!! >> >> Why are we using internal stuff outside the base bundle?? This needs to be >> fixed. >> > Hi, > Can someone explain, what's meant by "internal" here and whether any > convention has been violated? > >> Thanks, >> Senaka. >> >>> >>> >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] For more information, run Maven with the -e switch >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] Total time: 272 minutes 18 seconds >>> [INFO] Finished at: Wed Feb 16 03:14:31 IST 2011 >>> [INFO] Final Memory: 1154M/1785M >>> [INFO] >>> ------------------------------------------------------------------------ >>> _______________________________________________ >>> Carbon-dev mailing list >>> [email protected] >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >> >> >> >> -- >> *Senaka Fernando* >> Product Manager - WSO2 Governance Registry; >> Associate Technical Lead; WSO2, Inc.; http://wso2.com* >> Member; Apache Software Foundation; http://apache.org >> >> E-mail: senaka AT wso2.com >> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 >> Linked-In: http://www.linkedin.com/in/senakafernando >> >> *Lean . Enterprise . Middleware >> >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Thanks, > Denis > ---------------------------------------------------------- > *Denis Weerasiri* > Software Engineer; WSO2 Inc.; http://wso2.com, > *email: denis <http://goog_277208233/>** [AT] wso2.com* <http://wso2.com/> > * > blog: **http://ddweerasiri.blogspot.com*<http://ddweerasiri.blogspot.com/> > * > twitter: **http://twitter.com/ddweerasiri*<http://twitter.com/ddweerasiri> > * > linked-in: > **http://lk.linkedin.com/in/ddweerasiri*<http://lk.linkedin.com/in/ddweerasiri> > > > _______________________________________________ > Carbon-dev mailing list > [email protected] > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- *Afkham Azeez* Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, * * *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/> * email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
