Hi all, I am not sure if there is any permissions should be set in crucible project. If anyone knows this, please reply, I will add those permissions in next time.
Thank you. On Tue, Feb 22, 2011 at 3:03 PM, Heshan Suriyaarachchi <[email protected]>wrote: > I was not able to add comments to the Crucible project at that time. It may > be a permission issue or something. Nuwan also experienced the same thing. > That's why I took down the notes like this. I will add them to the crucible. > > > On Tue, Feb 22, 2011 at 2:35 PM, Afkham Azeez <[email protected]> wrote: > >> Notes have not been taken in Crucible? >> >> >> On Tue, Feb 22, 2011 at 11:53 AM, Heshan Suriyaarachchi >> <[email protected]>wrote: >> >>> Code Review Notes >>> =============== >>> >>> Participants : Azeez, Deep, Nandika, Manjula, Chmara, ChamaraA, Nuwan, >>> Ajith, Heshan >>> >>> JMSMessageBoxService.java >>> -------------------------------------------- >>> Synchronize the data structure, rather than synchronizing the whole >>> method >>> Remove the isAdminLoggedIn() method's hard-coded admin related logic. Add >>> role based access to service. >>> Refactor the code to have two OSGi Services - One to handle AdminServices >>> and one to handle others >>> If no message boxes are there, add a relevant message to the UI. >>> Add a small description of what a class/interface does at the top of the >>> class/interface. >>> Inside the handler handle the registry specific stuff >>> According to the current implementation, MessageBox wont work in Stratos. >>> Need to look into this aspect as well. >>> Fefactor the complex methods. ie. group the logic into methods and use >>> them within the complex method. >>> >>> >>> MessageAuthorizationHandler.java >>> -------------------------------------------------- >>> When retrieving the name of the messagebox, take tenant into >>> consideration. >>> >>> >>> Use ExecutorService instead of using a TimerTask >>> >>> >>> >>> >>> On Mon, Feb 21, 2011 at 9:20 AM, Manjula Rathnayake >>> <[email protected]>wrote: >>> >>>> more details >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=Yzc3dW5hZjI5dXQxNm1qZWF0c2o1MGoyazQgaGVzaGFuQHdzbzIuY29t&tok=MTcjbWFuanVsYXJAd3NvMi5jb21kNzdhODE3MDc5MWFlNmM0OWE1Yjk3OWM4MGI3ZDlkZWIxMGY2MmM0&ctz=Asia%2FColombo&hl=en> >>>> Group B code review (MessageBox) >>>> Crucible project can be found here. >>>> https://wso2.org/crucible/cru/COMPONENT-42<http://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FCOMPONENT-42&ust=1298267449835000&usg=AFQjCNEJzOAnRIXXUpLV97TG52rEBWlj8w> >>>> *When* >>>> Tue Feb 22 10:30am – 11:30am Colombo >>>> *Where* >>>> 3rd floor (map <http://maps.google.com/maps?q=3rd+floor&hl=en>) >>>> *Calendar* >>>> [email protected] >>>> *Who* >>>> • >>>> Manjula Rathnayake - organizer >>>> • >>>> Chamara Ariyarathne >>>> • >>>> Milinda Pathirage >>>> • >>>> Lahiru Gunathilake >>>> • >>>> Amal Rangana >>>> • >>>> Chamara Silva >>>> • >>>> Nuwan Bandara >>>> • >>>> [email protected] >>>> • >>>> Krishantha Samaraweera >>>> • >>>> Sanjeewa Malalgoda >>>> • >>>> Heshan Suriyaarachchi >>>> • >>>> Danushka Manikkumbura >>>> • >>>> Ajith Vitharana >>>> >>>> Going? >>>> *Yes<https://www.google.com/calendar/event?action=RESPOND&eid=Yzc3dW5hZjI5dXQxNm1qZWF0c2o1MGoyazQgaGVzaGFuQHdzbzIuY29t&rst=1&tok=MTcjbWFuanVsYXJAd3NvMi5jb21kNzdhODE3MDc5MWFlNmM0OWE1Yjk3OWM4MGI3ZDlkZWIxMGY2MmM0&ctz=Asia%2FColombo&hl=en>- >>>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=Yzc3dW5hZjI5dXQxNm1qZWF0c2o1MGoyazQgaGVzaGFuQHdzbzIuY29t&rst=3&tok=MTcjbWFuanVsYXJAd3NvMi5jb21kNzdhODE3MDc5MWFlNmM0OWE1Yjk3OWM4MGI3ZDlkZWIxMGY2MmM0&ctz=Asia%2FColombo&hl=en>- >>>> No<https://www.google.com/calendar/event?action=RESPOND&eid=Yzc3dW5hZjI5dXQxNm1qZWF0c2o1MGoyazQgaGVzaGFuQHdzbzIuY29t&rst=2&tok=MTcjbWFuanVsYXJAd3NvMi5jb21kNzdhODE3MDc5MWFlNmM0OWE1Yjk3OWM4MGI3ZDlkZWIxMGY2MmM0&ctz=Asia%2FColombo&hl=en> >>>> * more options >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=Yzc3dW5hZjI5dXQxNm1qZWF0c2o1MGoyazQgaGVzaGFuQHdzbzIuY29t&tok=MTcjbWFuanVsYXJAd3NvMi5jb21kNzdhODE3MDc5MWFlNmM0OWE1Yjk3OWM4MGI3ZDlkZWIxMGY2MmM0&ctz=Asia%2FColombo&hl=en> >>>> >>>> Invitation from Google Calendar <https://www.google.com/calendar/> >>>> >>>> You are receiving this email at the account [email protected] because you >>>> are subscribed for invitations on calendar [email protected]. >>>> >>>> To stop receiving these notifications, please log in to >>>> https://www.google.com/calendar/ and change your notification settings >>>> for this calendar. >>>> >>> >>> >>> >>> -- >>> Regards, >>> Heshan Suriyaarachchi >>> Software Engineer >>> WSO2 Inc.; http://wso2.com/ >>> >>> Blog: http://heshans.blogspot.com/ >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> [email protected] >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> *Afkham Azeez* >> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, >> * >> * >> *Member; Apache Software Foundation; >> **http://www.apache.org/*<http://www.apache.org/> >> * >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> > > > -- > Regards, > Heshan Suriyaarachchi > Software Engineer > WSO2 Inc.; http://wso2.com/ > > Blog: http://heshans.blogspot.com/ > -- Manjula Rathnayaka Software Engineer WSO2, Inc. Mobile:+94 77 743 1987
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
