I have seen many Java Beans with boolean fields, which you can call flags, but I haven't seen the Bean itself being called FlaggedFoo just because it contains boolean attributes. It's OK, not a major issue. I wouldn't name my classes like that though :)
On Sun, Mar 13, 2011 at 8:25 AM, Dimuthu Leelarathne <[email protected]>wrote: > > Hi, > > IANAL, but let me start ;) by quoting a few online dictionaries. Flag > means, > > - A symbol, value, or other means of identifying data of interest, or of > informing later parts of a program what conditions earlier parts have > encountered. > [1] > > -A variable or memory location that stores true-or-false, yes-or-no > information. [2] > > [1] http://dictionary.reference.com/browse/flag > [2] http://www.yourdictionary.com/flag > > This object is a Flagged name because we are putting two flags - > "isEditable" and "isSelected" on either user name or role name. And these > two boolean variables indicate to the later parts of a program what > conditions earlier parts have encountered (from above [1] ). In our > environment earlier part is BE. And later part is FE. > > Thanks, > Dimuthu > > > On Sun, Mar 13, 2011 at 8:06 AM, Afkham Azeez <[email protected]> wrote: > >> No I mean, why is it called FlaggedName? What is flagged? >> >> >> On Sun, Mar 13, 2011 at 8:04 AM, Dimuthu Leelarathne >> <[email protected]>wrote: >> >>> Hi, >>> >>> Context means getRoles, getUsersOfRole, getRolesOfUser. >>> >>> tx, >>> dimuthu >>> >>> >>> On Sat, Mar 12, 2011 at 11:46 PM, Afkham Azeez <[email protected]> wrote: >>> >>>> So, Flagged in this context means? >>>> >>>> >>>> On Sat, Mar 12, 2011 at 10:13 PM, Dimuthu Leelarathne < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> Here is the comment I wrote. >>>>> /** >>>>> * This is a classic sample of DTOs. >>>>> * An instance of this class can represent either an user item or role >>>>> item. >>>>> * This is used to represent items in lists of users and roles sent to >>>>> the Carbon FE. >>>>> * It contains information to indicate whether the representing item is >>>>> editable >>>>> * or selected within the given context. >>>>> */ >>>>> >>>>> Here are the use cases. >>>>> >>>>> Usecase 1 : When listing roles we should not show the editable link if >>>>> it is a external role. >>>>> >>>>> Before FlaggedName >>>>> 1) Send the complete role list (hybrid + external) to FE >>>>> 2) Send the role list that are external to FE >>>>> >>>>> When listing roles in FE go through both lists, and do not show edit >>>>> links for external roles. This logic in JSPs could not be reused. Idea was >>>>> to cut down the number of calls. It was a feedback given in a review. >>>>> >>>>> After FlaggedNames >>>>> 1) Send the list of FlaggedNames >>>>> >>>>> Usecase 2 : When user clicks on edit users of a Role >>>>> >>>>> Before FlaggedName >>>>> 1) Send the list of users that are already in the role so that I can >>>>> show the ticks in the GUI >>>>> 2) Send the complete requested user list to FE (selected by *) so I can >>>>> show them unchecked >>>>> >>>>> After FlaggedName >>>>> 1)Cut down the nubmer of calls going back and forth >>>>> >>>>> And many more to continue ..... And since I wrote two use cases I will >>>>> include them also in the comment. :) >>>>> >>>>> Thanks, >>>>> Dimuthu >>>>> >>>>> >>>>> On Sat, Mar 12, 2011 at 9:51 PM, Paul Fremantle <[email protected]> wrote: >>>>> >>>>>> And can you let us know what it is here? I'm all agog. >>>>>> >>>>>> Thx! >>>>>> Paul >>>>>> >>>>>> >>>>>> On 12 March 2011 15:52, Dimuthu Leelarathne <[email protected]>wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> My fault. I added it long time ago - maybe 2 years ago. I should have >>>>>>> added a comment. >>>>>>> >>>>>>> I will do that right now. >>>>>>> >>>>>>> Thanks, >>>>>>> Dimuthu >>>>>>> >>>>>>> On Sat, Mar 12, 2011 at 7:10 PM, Afkham Azeez <[email protected]>wrote: >>>>>>> >>>>>>>> org.wso2.carbon.user.mgt.common.FlaggedName >>>>>>>> >>>>>>>> I wouldn't have to ask if the author took 2 seconds to write a one >>>>>>>> line comment !!! >>>>>>>> >>>>>>>> So, once again people have stopped commenting their APIs, and given >>>>>>>> up on best practices (FindBugs etc.)? >>>>>>>> >>>>>>>> -- >>>>>>>> *Afkham Azeez* >>>>>>>> Senior Software Architect & Senior Manager; WSO2, Inc.; >>>>>>>> http://wso2.com, >>>>>>>> * >>>>>>>> * >>>>>>>> *Member; Apache Software Foundation; >>>>>>>> **http://www.apache.org/*<http://www.apache.org/> >>>>>>>> * >>>>>>>> email: **[email protected]* <[email protected]>* cell: >>>>>>>> <%2B94%2077%203320919> >>>>>>>> <%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919>+94 >>>>>>>> 77 3320919 >>>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>>>>>> twitter: >>>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>>>>>> * >>>>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>>>>>> * >>>>>>>> * >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Carbon-dev mailing list >>>>>>>> [email protected] >>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Carbon-dev mailing list >>>>>>> [email protected] >>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Paul Fremantle >>>>>> CTO and Co-Founder, WSO2 >>>>>> OASIS WS-RX TC Co-chair, VP, Apache Synapse >>>>>> >>>>>> Office: <%2B44%20844%20484%208143> >>>>>> <%2B44%20844%20484%208143><%2B44%20844%20484%208143><%2B44%20844%20484%208143><%2B44%20844%20484%208143><%2B44%20844%20484%208143>+44 >>>>>> 844 484 8143 >>>>>> Cell: <%2B44%20798%20447%204618> >>>>>> <%2B44%20798%20447%204618><%2B44%20798%20447%204618><%2B44%20798%20447%204618><%2B44%20798%20447%204618><%2B44%20798%20447%204618>+44 >>>>>> 798 447 4618 >>>>>> >>>>>> blog: http://pzf.fremantle.org >>>>>> twitter.com/pzfreo >>>>>> [email protected] >>>>>> >>>>>> wso2.com Lean Enterprise Middleware >>>>>> >>>>>> Disclaimer: This communication may contain privileged or other >>>>>> confidential information and is intended exclusively for the >>>>>> addressee/s. If >>>>>> you are not the intended recipient/s, or believe that you may have >>>>>> received >>>>>> this communication in error, please reply to the sender indicating that >>>>>> fact >>>>>> and delete the copy you received and in addition, you should not print, >>>>>> copy, retransmit, disseminate, or otherwise use the information >>>>>> contained in >>>>>> this communication. Internet communications cannot be guaranteed to be >>>>>> timely, secure, error or virus-free. The sender does not accept liability >>>>>> for any errors or omissions. >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Carbon-dev mailing list >>>>> [email protected] >>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com >>>> , >>>> * >>>> * >>>> *Member; Apache Software Foundation; >>>> **http://www.apache.org/*<http://www.apache.org/> >>>> * >>>> email: **[email protected]* <[email protected]>* cell: >>>> <%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919><%2B94%2077%203320919>+94 >>>> 77 3320919 >>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>> twitter: >>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>> * >>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>> * >>>> * >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>> >> >> >> -- >> *Afkham Azeez* >> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, >> * >> * >> *Member; Apache Software Foundation; >> **http://www.apache.org/*<http://www.apache.org/> >> * >> email: **[email protected]* <[email protected]>* cell: >> <%2B94%2077%203320919><%2B94%2077%203320919>+94 >> 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> > -- *Afkham Azeez* Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, * * *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/> * email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
