hi,

It is not a personal preference. It is wrong to use "-" in bundles. What
Tharidu is suggesting is wrong. The examples Tharindu has given are wrong.

We have clearly defined using the following versioning for bundles is the
wrong standard.
0.9.6.SNAPSHOT-wso2v1

It should either be one of the following.
0.9.6.SNAPSHOT.wso2v1
0.9.6.SNAPSHOTwso2v1

We haven't clearly defined the correct version from one of the above. So
let's create a standard now.

thanks,
dimuthu


On Wed, Mar 30, 2011 at 8:20 PM, Afkham Azeez <[email protected]> wrote:

>
>
> On Wed, Mar 30, 2011 at 8:17 PM, Tharindu Mathew <[email protected]>wrote:
>
>> On Wed, Mar 30, 2011 at 8:12 PM, Dimuthu Leelarathne 
>> <[email protected]>wrote:
>>
>>> Hi,
>>>
>>> On Wed, Mar 30, 2011 at 8:01 PM, Tharindu Mathew <[email protected]>wrote:
>>>
>>>> Take a look at how these orbit versions are done. It's still
>>>> number.number.number.qualifier !
>>>>
>>>> <wsdl-validator.version>1.2.0.SNAPSHOT-wso2v1</wsdl-validator.version>
>>>>
>>>>
>>> Wrong!! If this is a bundle correct version is wsdl-validator.wso2
>>>
>>>
>>>> <opensaml2.wso2.version>2.0.0.alpha1-wso2v1</opensaml2.wso2.version>
>>>>
>>>>
>>> Wrong again!!  This should either be
>>> 2.0.0.alpha1.wso2v1 or  2.0.0.alpha1wso2v1
>>>>
>>>>
>>> We can carry out a meaningful argument about picking one of the later. So
>>> you can argue that 0.9.6.SNAPSHOTwso2v1 should be 0.9.6.SNAPSHOT.wso2v1  :)
>>> But i prefer 0.9.6.SNAPSHOT.wso2v1 because it is simpler to me. Why?
>>> number.number.number.qualifier.
>>>
>> No arguments here :) Let's get the others to change :P
>>
>
>
> Just follow the convention everybody else has been following, and do not go
> for personal preferences. If you want to change the global versioning style,
> start a discussion on that.
>
>
>>
>>> Thanks,
>>> Dimuthu
>>>
>>> thanks,
>>> dimuthu
>>>
>>>
>>>>
>>>> On Wed, Mar 30, 2011 at 7:52 PM, Dimuthu Leelarathne <[email protected]
>>>> > wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> For dependencies you put the version like that. For orbit bundles the
>>>>> format is nubmer.nuber.number.qualifier.
>>>>>
>>>>> Thanks,
>>>>> Dimuthu
>>>>>
>>>>>
>>>>> On Wed, Mar 30, 2011 at 7:42 PM, Tharindu Mathew <[email protected]>wrote:
>>>>>
>>>>>> I believe then the version should 0.9.6.SNAPSHOT-wso2v1
>>>>>>
>>>>>>
>>>>>> On Wed, Mar 30, 2011 at 6:15 PM, Dimuthu Leelarathne <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> This is not a typo. I followed the format
>>>>>>> number.number.number.qualifier.
>>>>>>>
>>>>>>> Please see the commits 91237 and 91240
>>>>>>>
>>>>>>> thanks,
>>>>>>> dimuthu
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Mar 30, 2011 at 5:25 PM, Tharindu Mathew 
>>>>>>> <[email protected]>wrote:
>>>>>>>
>>>>>>>> 0.9.6.SNAPSHOTwso2v1?? What is this version?
>>>>>>>>
>>>>>>>> I built openid4java dependencies and orbit and changed the version
>>>>>>>> to 0.9.6-SNAPSHOT.wso2v1 in the component root pom and it works. So I 
>>>>>>>> assume
>>>>>>>> this is a typo that should not have been committed.
>>>>>>>>
>>>>>>>> I will commit this change. Please shout if you have a concern.
>>>>>>>>
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] Building WSO2 Carbon - Identity Provider
>>>>>>>> [INFO]    task-segment: [install]
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> Downloading:
>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public//org/openid4java/wso2/openid4java-nodeps/0.9.6.SNAPSHOTwso2v1/openid4java-nodeps-0.9.6.SNAPSHOTwso2v1.pom
>>>>>>>> [INFO] Unable to find resource
>>>>>>>> 'org.openid4java.wso2:openid4java-nodeps:pom:0.9.6.SNAPSHOTwso2v1' in
>>>>>>>> repository wso2-nexus (
>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public/)
>>>>>>>> Downloading:
>>>>>>>> http://repo1.maven.org/maven2/org/openid4java/wso2/openid4java-nodeps/0.9.6.SNAPSHOTwso2v1/openid4java-nodeps-0.9.6.SNAPSHOTwso2v1.pom
>>>>>>>> [INFO] Unable to find resource
>>>>>>>> 'org.openid4java.wso2:openid4java-nodeps:pom:0.9.6.SNAPSHOTwso2v1' in
>>>>>>>> repository central (http://repo1.maven.org/maven2)
>>>>>>>> Downloading:
>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public//org/openid4java/wso2/openid4java-nodeps/0.9.6.SNAPSHOTwso2v1/openid4java-nodeps-0.9.6.SNAPSHOTwso2v1.jar
>>>>>>>> [INFO] snapshot
>>>>>>>> org.wso2.carbon:org.wso2.carbon.identity.relyingparty:3.2.0-SNAPSHOT:
>>>>>>>> checking for updates from wso2-nexus
>>>>>>>> [INFO] Unable to find resource
>>>>>>>> 'org.openid4java.wso2:openid4java-nodeps:jar:0.9.6.SNAPSHOTwso2v1' in
>>>>>>>> repository wso2-nexus (
>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public/)
>>>>>>>> Downloading:
>>>>>>>> http://repo1.maven.org/maven2/org/openid4java/wso2/openid4java-nodeps/0.9.6.SNAPSHOTwso2v1/openid4java-nodeps-0.9.6.SNAPSHOTwso2v1.jar
>>>>>>>> [INFO] Unable to find resource
>>>>>>>> 'org.openid4java.wso2:openid4java-nodeps:jar:0.9.6.SNAPSHOTwso2v1' in
>>>>>>>> repository central (http://repo1.maven.org/maven2)
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> [ERROR] BUILD ERROR
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] Failed to resolve artifact.
>>>>>>>>
>>>>>>>> Missing:
>>>>>>>> ----------
>>>>>>>> 1) org.openid4java.wso2:openid4java-nodeps:jar:0.9.6.SNAPSHOTwso2v1
>>>>>>>>
>>>>>>>>   Try downloading the file manually from the project website.
>>>>>>>>
>>>>>>>>   Then, install it using the command:
>>>>>>>>       mvn install:install-file -DgroupId=org.openid4java.wso2
>>>>>>>> -DartifactId=openid4java-nodeps -Dversion=0.9.6.SNAPSHOTwso2v1
>>>>>>>> -Dpackaging=jar -Dfile=/path/to/file
>>>>>>>>
>>>>>>>>   Alternatively, if you host your own repository you can deploy the
>>>>>>>> file there:
>>>>>>>>       mvn deploy:deploy-file -DgroupId=org.openid4java.wso2
>>>>>>>> -DartifactId=openid4java-nodeps -Dversion=0.9.6.SNAPSHOTwso2v1
>>>>>>>> -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
>>>>>>>>
>>>>>>>>   Path to dependency:
>>>>>>>>       1)
>>>>>>>> org.wso2.carbon:org.wso2.carbon.identity.provider:bundle:3.2.0-SNAPSHOT
>>>>>>>>       2)
>>>>>>>> org.openid4java.wso2:openid4java-nodeps:jar:0.9.6.SNAPSHOTwso2v1
>>>>>>>>
>>>>>>>> ----------
>>>>>>>> 1 required artifact is missing.
>>>>>>>>
>>>>>>>> for artifact:
>>>>>>>>
>>>>>>>> org.wso2.carbon:org.wso2.carbon.identity.provider:bundle:3.2.0-SNAPSHOT
>>>>>>>>
>>>>>>>> from the specified remote repositories:
>>>>>>>>   central (http://repo1.maven.org/maven2),
>>>>>>>>   wso2-nexus (
>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public/)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] For more information, run Maven with the -e switch
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] Total time: 13 minutes 15 seconds
>>>>>>>> [INFO] Finished at: Wed Mar 30 17:07:55 IST 2011
>>>>>>>> [INFO] Final Memory: 488M/1694M
>>>>>>>> [INFO]
>>>>>>>> ------------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Tharindu
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Carbon-dev mailing list
>>>>>>>> [email protected]
>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>>
>>>>>> Tharindu
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>>
>>>> Tharindu
>>>>
>>>>
>>>
>>
>>
>> --
>> Regards,
>>
>> Tharindu
>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
>
> --
> *Afkham Azeez*
> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
> *
> *
> *Member; Apache Software Foundation; 
> **http://www.apache.org/*<http://www.apache.org/>
> *
> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>
_______________________________________________
Carbon-dev mailing list
[email protected]
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to