Hi Harshana,

On Mon, Apr 4, 2011 at 12:11 PM, Harshana Martin <[email protected]> wrote:

> Hi AmilaM,
>
> On Mon, Apr 4, 2011 at 10:59 AM, Amila Maha Arachchi <[email protected]>wrote:
>
>> Hi,
>>
>> AFAIU most of the products were broken due to integration test jar being
>> missing. We had to manually build the integration/core with tests to get rid
>> of this. After that many products were successfully built. I notices some
>> breaks in MS, CEP, ESB.
>>
>> We have a nother problem. Now we build using the command "mvn install".
>> Therefore the target doesn't get cleaned AFAIU. So if the build fails for a
>> certain product, it will still contain a recently built pack in the target
>> and it will get copied to the place where we host them. Then the QA folks
>> will test it and report errors.
>>
>
> If there are any changes to the product's components/features, it gets
> cleaned since we are including the features as dependencies. So this is not
>  a problem.
>
>>
>> I think we'll have to clean the product folders before building them (in
>> the build script).
>
>
> Isn't it a problem in the build script if it is copying the existing target
> in case of a build failure? Ideally if the build is failed, nothing should
> be copied irrespective of existence of target  folder. so fixing the build
> script to stop copying is the correct solution IMO.  Cleaning the product
> folder target will certainly work but i do not think that is the proper
> fix.
>

Yes, I agree with your argument. I have selected the easy path at the moment
because we have to provide packs asap. I will see what can be done to
improve the script to stop copying existing packs if the build fails.

Thanks,
AmilaM.

>
> Thanks and Regards,
> Harshana
>
>>
>> Thanks,
>> AmilaM.
>>
>> On Mon, Apr 4, 2011 at 8:35 AM, Samisa Abeysinghe <[email protected]>wrote:
>>
>>> There are many product builds in broken state...
>>>
>>> Thanks,
>>> Samisa...
>>>
>>> Samisa Abeysinghe
>>> VP Engineering
>>> WSO2 Inc.
>>> http://wso2.com
>>> http://wso2.org
>>>
>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> [email protected]
>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
>
> --
> Harshana Martin
> Software Engineer
> WSO2 Inc.
> Web:http://wso2.com
>           http://wso2.org
>
> Mobile: +94 716062650
> Blog: http://harshana05.blogspot.com
> Profile: https://www.google.com/profiles/harshana05
> Twitter: http://twitter.com/harshana05
>
>
_______________________________________________
Carbon-dev mailing list
[email protected]
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to