Hi Senaka, +1. Yes, we need to fix all the occurrences, where the 'setters that modified the lastupdated timestamp internally', invoked by a get operation of a class(e.g:SymLinkHandler) and replace them with the corresponding *WithNoUpdate() methods.
Thanks, Fazlan On Wed, Apr 27, 2011 at 11:08 PM, Fazlan Sabar <[email protected]> wrote: > Hi Senaka, > > There wasn't a JIRA directly associated with this, I found this error in > SymLinkHandler while I was testing after fixing JIRA Key: CARBON-8284. And > same error was apparent in MountHandler, although I applied it today. > > Thanks, > Fazlan. > > > On Wed, Apr 27, 2011 at 11:02 PM, Senaka Fernando <[email protected]> wrote: > >> Hi Fazlan, >> >> Isn't this the fix that we discussed today? where changes were made to the >> SymlinkHandler and not the MountHandler? I was under the impression that we >> had a JIRA issue for that. Plus, we need to fix the method calls responsible >> for setting/removing properties as well right? They too have a *withUpdate >> version isn't it? >> >> Thanks, >> Senaka. >> >> On Wed, Apr 27, 2011 at 10:56 PM, Fazlan Sabar <[email protected]> wrote: >> >>> Hi, >>> >>> No, there isn't a JIRA for this, but this was an issue identified. >>> >>> Thanks, >>> Fazlan >>> >>> On Wed, Apr 27, 2011 at 5:38 PM, Afkham Azeez <[email protected]> wrote: >>> >>>> Is there a JIRA for this? If so, you MUST include that JIRA key in your >>>> commit message. We have JIRA+SVN integration, so we can view a JIRA, all >>>> the >>>> related file changes related to the fixes for that JIRA. >>>> >>>> >>>> On Wed, Apr 27, 2011 at 3:50 PM, <[email protected]> wrote: >>>> >>>>> Author: fazlan >>>>> Date: Wed Apr 27 03:20:15 2011 >>>>> New Revision: 92696 >>>>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=92696 >>>>> >>>>> Log: >>>>> Fixed updating of the last modified timestamp field of resource when >>>>> setting the content. >>>>> >>>>> >>>>> Modified: >>>>> >>>>> trunk/carbon/core/org.wso2.carbon.registry.core/src/main/java/org/wso2/carbon/registry/core/jdbc/handlers/builtin/MountHandler.java >>>>> >>>>> Modified: >>>>> trunk/carbon/core/org.wso2.carbon.registry.core/src/main/java/org/wso2/carbon/registry/core/jdbc/handlers/builtin/MountHandler.java >>>>> URL: >>>>> http://wso2.org/svn/browse/wso2/trunk/carbon/core/org.wso2.carbon.registry.core/src/main/java/org/wso2/carbon/registry/core/jdbc/handlers/builtin/MountHandler.java?rev=92696&r1=92695&r2=92696&view=diff >>>>> >>>>> ============================================================================== >>>>> --- >>>>> trunk/carbon/core/org.wso2.carbon.registry.core/src/main/java/org/wso2/carbon/registry/core/jdbc/handlers/builtin/MountHandler.java >>>>> (original) >>>>> +++ >>>>> trunk/carbon/core/org.wso2.carbon.registry.core/src/main/java/org/wso2/carbon/registry/core/jdbc/handlers/builtin/MountHandler.java >>>>> Wed Apr 27 03:20:15 2011 >>>>> @@ -398,7 +398,7 @@ >>>>> } finally { >>>>> setInExecution(true); >>>>> } >>>>> - tempResource.setContent(nonLinkPaths.toArray(new >>>>> String[nonLinkPaths.size()])); >>>>> + ((ResourceImpl) >>>>> tempResource).setContentWithNoUpdate(nonLinkPaths.toArray(new >>>>> String[nonLinkPaths.size()])); >>>>> } >>>>> ((ResourceImpl) tempResource).setPath(fullPath); >>>>> ((ResourceImpl) >>>>> tempResource).setAuthorUserName(author); >>>>> _______________________________________________ >>>>> Carbon-commits mailing list >>>>> [email protected] >>>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits >>>>> >>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com >>>> , >>>> * >>>> * >>>> *Member; Apache Software Foundation; >>>> **http://www.apache.org/*<http://www.apache.org/> >>>> * >>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>> twitter: >>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>> * >>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>> * >>>> * >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>> >>> >>> -- >>> Thanks, >>> Fazlan >>> >>> >>> _______________________________________________ >>> Carbon-commits mailing list >>> [email protected] >>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits >>> >>> >> >> >> -- >> *Senaka Fernando* >> Product Manager - WSO2 Governance Registry; >> Associate Technical Lead; WSO2, Inc.; http://wso2.com* >> Member; Apache Software Foundation; http://apache.org >> >> E-mail: senaka AT wso2.com >> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 >> Linked-In: http://www.linkedin.com/in/senakafernando >> >> *Lean . Enterprise . Middleware >> >> > > > -- > Thanks, > Fazlan > > -- Thanks, Fazlan
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
