Adding my thoughts.. I think the samples in all the products should have a consistent parent pom hierarchy. Going forward in this approach, I see that the Application Server uses "wso2appserver-samples" (products/as/modules/samples/product/pom.xml) as the parent of the samples in products/as/modules/samples/product/. IS uses wso2is-identity-samples. As such, greg samples should use the parent "governance-samples" for the samples in products/greg/modules/samples/product. Just a thought!
Regards, --KasunG On Thu, Dec 8, 2011 at 12:47 AM, Harshana Martin <[email protected]> wrote: > > ---------- Forwarded message ---------- > From: <[email protected]> > Date: Fri, Nov 18, 2011 at 10:12 AM > Subject: [Carbon-commits] [Carbon] svn commit r115805 - in > trunk/carbon/products/greg/modules/samples/product: . > jcr-client/src/org.wso2.carbon.registry.jcr.client shutterbug/src > shutterbug/src/org.wso2.governance.samples.shutterbug > shutterbug/src/org.wso2.governance.samples.shutterbug.ui > To: [email protected] > > > Author: isuruw > Date: Thu Nov 17 20:42:16 2011 > New Revision: 115805 > URL: http://wso2.org/svn/browse/wso2?view=rev&revision=115805 > > Log: > pom.xml changes inside greg.modules.samples > > Modified: > > trunk/carbon/products/greg/modules/samples/product/jcr-client/src/org.wso2.carbon.registry.jcr.client/pom.xml > trunk/carbon/products/greg/modules/samples/product/pom.xml > > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug.ui/pom.xml > > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug/pom.xml > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/pom.xml > > Modified: > trunk/carbon/products/greg/modules/samples/product/jcr-client/src/org.wso2.carbon.registry.jcr.client/pom.xml > URL: > http://wso2.org/svn/browse/wso2/trunk/carbon/products/greg/modules/samples/product/jcr-client/src/org.wso2.carbon.registry.jcr.client/pom.xml?rev=115805&r1=115804&r2=115805&view=diff > > ============================================================================== > --- > trunk/carbon/products/greg/modules/samples/product/jcr-client/src/org.wso2.carbon.registry.jcr.client/pom.xml > (original) > +++ > trunk/carbon/products/greg/modules/samples/product/jcr-client/src/org.wso2.carbon.registry.jcr.client/pom.xml > Thu Nov 17 20:42:16 2011 > @@ -2,11 +2,13 @@ > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > <parent> > - <groupId>org.wso2.governance</groupId> > - <artifactId>jcr-client</artifactId> > - <version>4.0.0-SNAPSHOT</version> > + <groupId>org.wso2.carbon</groupId> > + <artifactId>registry</artifactId> > + <version>3.2.0-SNAPSHOT</version> > </parent> > + > <modelVersion>4.0.0</modelVersion> > + <version>4.0.0-SNAPSHOT</version> > <artifactId>org.wso2.carbon.registry.jcr.client</artifactId> > <packaging>bundle</packaging> > <name>WSO2 Governance Registry - JCR Client</name> > @@ -68,17 +70,15 @@ > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.core</artifactId> > - <version>${carbon.version}</version> > </dependency> > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.jcr</artifactId> > - <version>${carbon.version}</version> > + <version>3.2.0-SNAPSHOT</version> > </dependency> > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.common</artifactId> > - <version>${carbon.version}</version> > </dependency> > <dependency> > <groupId>org.apache.ws.commons.axiom.wso2</groupId> > > Modified: trunk/carbon/products/greg/modules/samples/product/pom.xml > URL: > http://wso2.org/svn/browse/wso2/trunk/carbon/products/greg/modules/samples/product/pom.xml?rev=115805&r1=115804&r2=115805&view=diff > > ============================================================================== > --- trunk/carbon/products/greg/modules/samples/product/pom.xml (original) > +++ trunk/carbon/products/greg/modules/samples/product/pom.xml Thu Nov 17 > 20:42:16 2011 > @@ -23,13 +23,15 @@ > <artifactId>governance-samples-parent</artifactId> > <version>4.0.0-SNAPSHOT</version> > </parent> > + > <modelVersion>4.0.0</modelVersion> > <artifactId>governance-samples</artifactId> > <packaging>pom</packaging> > <name>WSO2 Governance Registry - Samples</name> > <modules> > - <module>shutterbug/src</module> > - > <module>distributed-LCM/src/org.wso2.carbon.governance.samples.lcm</module> > + > <module>shutterbug/src/org.wso2.governance.samples.shutterbug</module> > + > <module>shutterbug/src/org.wso2.governance.samples.shutterbug.ui</module> > + > <module>distributed-LCM/src/org.wso2.carbon.governance.samples.lcm</module> > > <module>distributed-LCM/src/org.wso2.carbon.governance.samples.lcm.notifications</module> > > <module>custom-ui/src/org.wso2.carbon.registry.samples.custom.topics</module> > > <module>custom-ui/src/org.wso2.carbon.registry.samples.custom.topics.ui</module> > @@ -123,6 +125,7 @@ > <dependency> > <groupId>commons-digester</groupId> > <artifactId>commons-digester</artifactId> > + <version>${commons.digester.version}</version> > </dependency> > <dependency> > <groupId>org.wso2.carbon</groupId> > @@ -132,20 +135,23 @@ > <dependency> > <groupId>junit</groupId> > <artifactId>junit</artifactId> > + <version>${junit.version}</version> > <scope>test</scope> > </dependency> > <dependency> > <groupId>commons-dbcp</groupId> > <artifactId>commons-dbcp</artifactId> > -<version>${orbit.version.commons.dbcp}</version> > + <version>${orbit.version.commons.dbcp}</version> > </dependency> > -<dependency> > + <dependency> > <groupId>javax.mail</groupId> > <artifactId>mail</artifactId> > + <version>${javax.mail.version}</version> > </dependency> > <dependency> > <groupId>javax.activation</groupId> > <artifactId>activation</artifactId> > + <version>${javax.activation.version}</version> > </dependency> > <dependency> > <groupId>commons-fileupload</groupId> > @@ -162,9 +168,10 @@ > <artifactId>geronimo-stax-api_1.0_spec</artifactId> > > <version>${version.geronimo.specs.geronimo-jpa_2.0_spec}</version> > </dependency> > -<dependency> > + <dependency> > <groupId>org.codehaus.woodstox</groupId> > <artifactId>wstx-asl</artifactId> > + <version>${wstx.asl.version}</version> > <scope>runtime</scope> > </dependency> > <dependency> > @@ -190,11 +197,13 @@ > <dependency> > <groupId>org.mortbay.jetty</groupId> > <artifactId>jetty</artifactId> > + <version>${jetty.version}</version> > <scope>test</scope> > </dependency> > <dependency> > <groupId>org.mortbay.jetty</groupId> > <artifactId>jetty-util</artifactId> > + <version>${jetty.util.version}</version> > <scope>test</scope> > </dependency> > <dependency> > @@ -205,6 +214,7 @@ > <dependency> > <groupId>eclipse</groupId> > <artifactId>validateutility</artifactId> > + <version>${eclipse.validateutility.version}</version> > </dependency> > <dependency> > <groupId>org.wso2.wsdl.validator.wso2</groupId> > @@ -231,6 +241,14 @@ > <xml.api.wso2.version>1.3.04.wso2v1</xml.api.wso2.version> > <xmlschema.wso2.version>1.4.7.wso2v1</xmlschema.wso2.version> > > > <wsdl.validator.wso2.version>1.2.0-SNAPSHOT.wso2v1</wsdl.validator.wso2.version> > +<commons.digester.version>1.8.1</commons.digester.version> > +<junit.version>3.8.1</junit.version> > +<javax.mail.version>1.4.0</javax.mail.version> > +<javax.activation.version>1.1.0</javax.activation.version> > +<wstx.asl.version>3.2.9</wstx.asl.version> > +<jetty.version>6.1.26</jetty.version> > +<jetty.util.version>6.0.2</jetty.util.version> > +<eclipse.validateutility.version>0.95</eclipse.validateutility.version> > </properties> > > </project> > > Modified: > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug.ui/pom.xml > URL: > http://wso2.org/svn/browse/wso2/trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug.ui/pom.xml?rev=115805&r1=115804&r2=115805&view=diff > > ============================================================================== > --- > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug.ui/pom.xml > (original) > +++ > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug.ui/pom.xml > Thu Nov 17 20:42:16 2011 > @@ -16,11 +16,13 @@ > <project xmlns="http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > + > <parent> > - <groupId>org.wso2.governance</groupId> > - <artifactId>shutterbug</artifactId> > - <version>4.0.0-SNAPSHOT</version> > - </parent> > + <groupId>org.wso2.carbon</groupId> > + <artifactId>governance</artifactId> > + <version>3.2.0-SNAPSHOT</version> > + </parent> > + > <modelVersion>4.0.0</modelVersion> > <artifactId>org.wso2.governance.samples.shutterbug.ui</artifactId> > <packaging>bundle</packaging> > @@ -131,12 +133,12 @@ > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.ui</artifactId> > - <version>${carbon.version}</version> > + <!--version>${carbon.version}</version--> > </dependency> > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.common.ui</artifactId> > - <version>${carbon.version}</version> > + <!--version>${carbon.version}</version--> > </dependency> > </dependencies> > </project> > > Modified: > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug/pom.xml > URL: > http://wso2.org/svn/browse/wso2/trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug/pom.xml?rev=115805&r1=115804&r2=115805&view=diff > > ============================================================================== > --- > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug/pom.xml > (original) > +++ > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/org.wso2.governance.samples.shutterbug/pom.xml > Thu Nov 17 20:42:16 2011 > @@ -18,11 +18,18 @@ > <project xmlns="http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > - <parent> > + <!--parent> > <groupId>org.wso2.governance</groupId> > <artifactId>shutterbug</artifactId> > <version>4.0.0-SNAPSHOT</version> > + </parent--> > + > +<parent> > + <groupId>org.wso2.carbon</groupId> > + <artifactId>governance</artifactId> > + <version>3.2.0-SNAPSHOT</version> > </parent> > > Hi IsuruW, > > Could you please explain the rationale of > declaring org.wso2.carbon:governance:3.2.0-SNAPSHOT as the parent > of org.wso2.governance.samples.shutterbug artifact instead of shutterbug > which is the parent module of org.wso2.governance.samples.shutterbug > module? > > Thanks and Regards, > Harshana > > + > <modelVersion>4.0.0</modelVersion> > <artifactId>org.wso2.governance.samples.shutterbug</artifactId> > <packaging>bundle</packaging> > @@ -85,12 +92,12 @@ > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.core</artifactId> > - <version>${carbon.version}</version> > + <!--version>${carbon.version}</version--> > </dependency> > <dependency> > <groupId>org.wso2.carbon</groupId> > <artifactId>org.wso2.carbon.registry.common</artifactId> > - <version>${carbon.version}</version> > + <!--version>${carbon.version}</version--> > </dependency> > <dependency> > <groupId>org.apache.ws.commons.axiom.wso2</groupId> > > Modified: > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/pom.xml > URL: > http://wso2.org/svn/browse/wso2/trunk/carbon/products/greg/modules/samples/product/shutterbug/src/pom.xml?rev=115805&r1=115804&r2=115805&view=diff > > ============================================================================== > --- > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/pom.xml > (original) > +++ > trunk/carbon/products/greg/modules/samples/product/shutterbug/src/pom.xml > Thu Nov 17 20:42:16 2011 > @@ -29,7 +29,7 @@ > <packaging>pom</packaging> > <name>WSO2 Governance Registry - Shutterbug Sample</name> > <modules> > - <module>org.wso2.governance.samples.shutterbug</module> > - <module>org.wso2.governance.samples.shutterbug.ui</module> > + <!--module>org.wso2.governance.samples.shutterbug</module> > + <module>org.wso2.governance.samples.shutterbug.ui</module--> > </modules> > </project> > _______________________________________________ > Carbon-commits mailing list > [email protected] > https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits > > > > -- > Harshana Martin > Software Engineer > WSO2 Inc. > Web:http://wso2.com > http://wso2.org > > Mobile: +94 716062650 > Blog: http://harshana05.blogspot.com > Profile: https://www.google.com/profiles/harshana05 > Twitter: http://twitter.com/harshana05 > > > _______________________________________________ > Carbon-dev mailing list > [email protected] > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > >
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
