I'd like to reiterate that you need to run FindBugs on your code before creating the patch or committing.
On Fri, Dec 16, 2011 at 8:46 PM, Afkham Azeez <az...@wso2.com> wrote: > This team will work from #59 in hackathon mode. I will be around so feel > free to catch me if you have any issues or need to figure out something. > Those of you who are not committers, please submit patches & assign them to > me. You need to make sure that you have executed FindBugs on the code, and > have followed all coding conventions & best practices, else the patch will > get rejected. > > Thanks > Azeez > > On Fri, Dec 16, 2011 at 3:32 PM, Afkham Azeez <az...@wso2.com> wrote: > >> The following team of people will be working on product integration >> testing over the next 3 working weeks. They will start working on this >> immediately. The objective is to improve the code coverage of all products. >> Nobody has been assigned from G-Reg & Carbon core. >> >> BPS - Keheliya >> BAM - Sinthuja >> DSS - Shelan and Lakmali >> Achala and Maninda will be working on GS and MS >> GS - Achala >> MS - Maninda >> CEP - Suhothayan >> BRS - Ishara >> AS - KasunG >> IS - Johann >> ESB - Nuwan and Ishan >> G-Reg - ? >> Carbon Core - ? >> >> *Plan for each product* >> 1. Spend up to one day learning TestNG >> 2. Migrate existing integration tests to TestNG. This has already been >> done for Carbon core, AS & BRS >> 3. Fix all failing integration tests >> 4. Add SecurityVerification test to each product >> 5. Identify the functional areas of each product & add integration tests >> >> *Best Practices* >> 1. No sysouts after running tests. Use assert statements. >> 2. Comments & test descriptions should be adde >> 3. Follow coding conventions >> 4. Do not follow the "Catch & Fail" antipattern [0]. If exceptions are >> expected, use the @ExpectedExceptions [1] annotation. Throw all unexpected >> exceptions from the test methods so that these tests result in errors, not >> failures. >> >> Team, please make this an opportunity to learn & master the art of unit & >> integration testing. >> >> Thanks >> Azeez >> >> 0. >> http://www.exubero.com/junit/antipatterns.html#Catching_Unexpected_Exceptions >> 1. >> http://testng.org/javadoc/org/testng/annotations/ExpectedExceptions.html >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://www.apache.org/ > * <http://www.apache.org/>** > email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 > blog: **http://blog.afkham.org* <http://blog.afkham.org>* > twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> > * > linked-in: **http://lk.linkedin.com/in/afkhamazeez* > * > * > *Lean . Enterprise . Middleware* > > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
