I looked into some of the errors reported by Sonar and looks like it is a good idea to fix them all.
Can some Java geeks please look into this and comment on the fact if it is a good idea to trust Sonar and just fix them all and make it to count zero warnings. On Wed, Jan 4, 2012 at 3:05 PM, Samisa Abeysinghe <sam...@wso2.com> wrote: > > > On Wed, Jan 4, 2012 at 2:59 PM, Charith Wickramarachchi > <char...@wso2.com>wrote: > >> >> >> On Wed, Jan 4, 2012 at 9:53 AM, Charith Wickramarachchi <char...@wso2.com >> > wrote: >> >>> >>> >>> On Tue, Jan 3, 2012 at 2:20 PM, Charith Wickramarachchi < >>> char...@wso2.com> wrote: >>> >>>> >>>> >>>> On Tue, Jan 3, 2012 at 1:40 PM, Srinath Perera <srin...@wso2.com>wrote: >>>> >>>>> Hi Samisa, >>>>> >>>>> Sonar runs on top of the source code, and Charith is working on it >>>>> making sonar work with our build. He will give details. >>>>> >>>>> >>>> Hi Samisa, >>>> >>>> Basically what we use is sonar maven plugin where it runs the maven >>>> goal sonar after the build. In that case it generate reports using >>>> instrumentation of the code and static analysis. >>>> >>>> Please find the latest report at[1]. But this is only for >>>> carbon-core. And i had to ignore the component org.wso2.carbon.thread >>>> to avoid an issue that we face with Sonar even after fixing a problem >>>> with source structure of that component. >>>> >>>> Issue is it gives a Duplicate class Error since we are having the class >>>> java.lang.Thread in that component. >>>> >>>> >>> >>> Hi , >>> >>> When we are running sonar analysis on carbon trunk there is a blocker is >>> carbon core which prevents sonar from generating reports. >>> Its the carbon threading module. First sonar failed in that module due >>> to the wrong source structure it had but even after fixing it in the >>> builder now it fails since that module also have a class named >>> :*java.lang.Thread >>> *. >>> >>> So currently i m excluding that module when running the sonar task. I >>> couldn't find a way to do it without changing the pom. >>> So i m thinking of using a different pom locally in the builder machine >>> so that Report generation task can use that pom to do the report >>> generation. >>> >>> Is there any better way to do this ? suggestions ? >>> >>> And also i'm seeing some random issues due to felix plugin we use, >>> mainly when it tries to extract jar files. >>> >>> >>> I have started a build to get reports for core and components will >>> update the results when i have them. >>> >> >> New report >> http://wso2.org/sonar/dashboard/index/156 >> > > This is more like it :) > > Now we got to fix all those issues! > > > Thanks, > Samisa... > > Samisa Abeysinghe > VP Engineering > WSO2 Inc. > http://wso2.com > http://wso2.org > > Thanks, Samisa... Samisa Abeysinghe VP Engineering WSO2 Inc. http://wso2.com http://wso2.org
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
