Hi Shariq, On Wed, Jan 4, 2012 at 5:30 PM, Muhammed Shariq <[email protected]> wrote:
> On Wed, Jan 4, 2012 at 5:26 PM, Harshana Martin <[email protected]> wrote: > >> Hi AmilaM, >> >> On Wed, Jan 4, 2012 at 5:20 PM, Amila Maha Arachchi <[email protected]>wrote: >> >>> Hi Harshana, >>> >>> Why do we need to set the relative path as in this commit. All the other >>> modules' poms have the relative path as ../../pom.xml >>> >> >> In this module pom, it has stated *carbon-platform *module as its >> parent. WRT the current location, *carbon-platform *is located in >> ../../../../pom.xml location. >> >> I think other modules haven't referred *carbon-platform *as their parent >> module :). >> > > Actually the parent shouldn't be *carbon-platform* rather it should > be*wso2manager-parent > * which is the parent of manager, right ? If there aren't any concerns I > can fix it accordingly ? > +1 I didn't make that change since I wasn't sure if there is an specific reason NOT to use manager-parent as its parent. If there is no such reason, please go ahead and make the change and adjust the relative path accordingly. Thanks and Regards, Harshana > >> Thanks and Regards, >> Harshana >> >>> >>> Just wanted to understand the reason. >>> >>> Thanks, >>> AmilaM. >>> >>> >>> On Wed, Jan 4, 2012 at 5:07 PM, <[email protected]> wrote: >>> >>>> Author: harshana >>>> Date: Wed Jan 4 03:37:52 2012 >>>> New Revision: 118599 >>>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=118599 >>>> >>>> Log: >>>> Fixed build break due to wrong relative path >>>> >>>> Modified: >>>> trunk/carbon/products/manager/modules/features-dashboard/pom.xml >>>> >>>> Modified: >>>> trunk/carbon/products/manager/modules/features-dashboard/pom.xml >>>> URL: >>>> http://wso2.org/svn/browse/wso2/trunk/carbon/products/manager/modules/features-dashboard/pom.xml?rev=118599&r1=118598&r2=118599&view=diff >>>> >>>> ============================================================================== >>>> --- trunk/carbon/products/manager/modules/features-dashboard/pom.xml >>>> (original) >>>> +++ trunk/carbon/products/manager/modules/features-dashboard/pom.xml >>>> Wed Jan 4 03:37:52 2012 >>>> @@ -8,7 +8,7 @@ >>>> <groupId>org.wso2.carbon</groupId> >>>> <artifactId>carbon-platform</artifactId> >>>> <version>3.2.0-SNAPSHOT</version> >>>> - <relativePath>../../pom.xml</relativePath> >>>> + <relativePath>../../../../pom.xml</relativePath> >>>> </parent> >>>> >>>> >>>> _______________________________________________ >>>> Carbon-commits mailing list >>>> [email protected] >>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits >>>> >>> >>> >>> >>> -- >>> *Amila Maharachchi* >>> Senior Software Engineer; WSO2, Inc.; http://wso2.com >>> >>> Blog: http://maharachchi.blogspot.com >>> Mobile: +94719371446 >>> >>> >>> >> >> >> -- >> Harshana Martin >> Software Engineer >> WSO2 Inc. >> Web:http://wso2.com >> http://wso2.org >> >> Mobile: +94 716062650 >> Blog: http://harshana05.blogspot.com >> Profile: https://www.google.com/profiles/harshana05 >> Twitter: http://twitter.com/harshana05 >> >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Thanks, > Shariq. > Phone: +94 777 202225 > > > _______________________________________________ > Carbon-dev mailing list > [email protected] > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Harshana Martin Software Engineer WSO2 Inc. Web:http://wso2.com http://wso2.org Mobile: +94 716062650 Blog: http://harshana05.blogspot.com Profile: https://www.google.com/profiles/harshana05 Twitter: http://twitter.com/harshana05
_______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
