The double comparison test in commons-vfs has issues. This is the problem
code. Look at the comment. I think we should simply comment out this test
given that this code is not primarily maintained by us.
if
(getReadFolder().getFileSystem().hasCapability(Capability.SET_LAST_MODIFIED_FILE))
{
// Try a file
final FileObject file =
getReadFolder().resolveFile("file1.txt");
file.getContent().setLastModifiedTime(now);
try
{
assertEquals(now, file.getContent().getLastModifiedTime(),
file.getFileSystem().getLastModTimeAccuracy());
}
catch (AssertionFailedError e)
{
* // on linux ext3 the above check is not necessarily true*
if (file.getFileSystem().getLastModTimeAccuracy() < 1000L)
{
assertEquals(now,
file.getContent().getLastModifiedTime(), 1000L);
}
else
{
throw e;
}
}
}
On Mon, Jan 9, 2012 at 6:39 AM, Samisa Abeysinghe <[email protected]> wrote:
>
>
> On Mon, Jan 9, 2012 at 6:36 AM, Afkham Azeez <[email protected]> wrote:
>
>> These are all weird failures. Even the ServerAdminTestCase failure is
>> something weird which we have never seen before, and there were no changes
>> in the code either.
>
>
> My feeling is that, the tests are not ideal.
>
> Intermittent failures mean two things, either
> 1. The test is not right
> or
> 2. The code being tested has an issue
>
>
>
>>
>>
>> On Mon, Jan 9, 2012 at 6:30 AM, Samisa Abeysinghe <[email protected]>wrote:
>>
>>> This failure shows that our tests cannot be predicted to pass all the
>>> time:
>>>
>>> e.g.
>>>
>>>
>>> junit.framework.AssertionFailedError: expected:<1.32605673E12> but
>>> was:<1.3260566E12>
>>>
>>>
>>> It seems to fail on the 7th decimal point. This could be a real failure,
>>> given it is testing setting last modified time.
>>>
>>>
>>> On Mon, Jan 9, 2012 at 5:52 AM, Bamboo <[email protected]> wrote:
>>>
>>>> [image: Failed] WSO2 Carbon
>>>> Trunk<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK/>›
>>>> WSO2
>>>> Carbon - Platform
>>>> Trunk<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK/>›
>>>> #87<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/>
>>>> failed
>>>>
>>>> This build was triggered at the scheduled time of 12:00 PM
>>>>
>>>> *3/7771* tests failed.
>>>> Failing
>>>> Jobs<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/>
>>>> Job
>>>> Duration Tests [image: Failed] WSO2 Carbon Trunk Build
>>>> Process<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/>
>>>> (Default
>>>> Stage) 250 minutes 3 of 7771 failed
>>>> Logs<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/log>|
>>>> Artifacts<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/artifact>
>>>> Code
>>>> Changes<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/commit/>
>>>> View
>>>> all 4 code
>>>> changes<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/commit/>
>>>> harshana<http://builder4.us1.wso2.org:8888/bamboo/browse/author/harshana>
>>>> Added maven incremental build plugin 118750
>>>> harshana<http://builder4.us1.wso2.org:8888/bamboo/browse/author/harshana>
>>>> Included maven incremental build plugin in to hector wso2 dependency
>>>> 118742
>>>> harshana<http://builder4.us1.wso2.org:8888/bamboo/browse/author/harshana>
>>>> Included maven incremental build plugin in to svn client wso2 bundle
>>>> 118741 1 more
>>>> changes…<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/commit>
>>>> Tests<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/test>
>>>> View
>>>> full test
>>>> details<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87/test>
>>>> 3
>>>> New Test Failures Test Job LastModifiedTests
>>>> testSetLastModified<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test/case/1617384>
>>>> WSO2
>>>> Carbon Trunk Build
>>>> Process<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test>
>>>> TestAsyncNHttpHandlers
>>>> testHttpException<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test/case/1614609>
>>>> WSO2
>>>> Carbon Trunk Build
>>>> Process<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test>
>>>> ServerAdminTestCase
>>>> testRetrieveServerInfo<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test/case/1619400>
>>>> WSO2
>>>> Carbon Trunk Build
>>>> Process<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-JOB1-87/test>
>>>> View
>>>> Online<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87>
>>>> | Add
>>>> Comments<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONTUNK-WSO2CARBONPLATFORMTRUNK-87?commentMode=true>
>>>>
>>>> This message was sent by Atlassian
>>>> Bamboo<http://builder4.us1.wso2.org:8888/bamboo>
>>>> .
>>>>
>>>> If you wish to stop receiving these emails edit your user
>>>> profile<http://builder4.us1.wso2.org:8888/bamboo/profile/userNotifications.action>or
>>>> notify
>>>> your
>>>> administrator<http://builder4.us1.wso2.org:8888/bamboo/viewAdministrators.action>
>>>> .
>>>>
>>>> _______________________________________________
>>>> Carbon-dev mailing list
>>>> [email protected]
>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>
>>>> Thanks,
>>> Samisa...
>>>
>>> Samisa Abeysinghe
>>> VP Engineering
>>> WSO2 Inc.
>>> http://wso2.com
>>> http://wso2.org
>>>
>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> [email protected]
>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Director of Architecture; WSO2, Inc.; http://wso2.com
>> Member; Apache Software Foundation; http://www.apache.org/
>> * <http://www.apache.org/>**
>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>> *
>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>> *
>> *
>> *Lean . Enterprise . Middleware*
>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>> Thanks,
> Samisa...
>
> Samisa Abeysinghe
> VP Engineering
> WSO2 Inc.
> http://wso2.com
> http://wso2.org
>
>
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
--
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/
* <http://www.apache.org/>**
email: **[email protected]* <[email protected]>* cell: +94 77 3320919
blog: **http://blog.afkham.org* <http://blog.afkham.org>*
twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
_______________________________________________
Carbon-dev mailing list
[email protected]
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
