On Wed, Jan 11, 2012 at 1:51 PM, Senaka Fernando <[email protected]> wrote: > Hi Amila, > > Just wondering why the method getSAML2Attribute() accepts the same parameter > twice? Is this different in other places, or can't we get rid of one > parameter?
Method is used more than once in the code. Thus the parameter values can be different. Thanks AmilaJ > > Thanks, > Senaka. > > On Wed, Jan 11, 2012 at 1:28 PM, Afkham Azeez <[email protected]> wrote: >> >> Please remove the year from the license header. >> >> Also, do you think it is a good idea to add a test case for this fix? >> >> >> On Wed, Jan 11, 2012 at 12:14 PM, <[email protected]> wrote: >>> >>> Author: amilaj >>> Date: Tue Jan 10 22:44:40 2012 >>> New Revision: 118821 >>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=118821 >>> >>> Log: >>> Fixing issue CARBON-10878. Made attribute statement use claim URI instead >>> of name >>> >>> Modified: >>> >>> trunk/carbon/components/identity/org.wso2.carbon.identity.provider/src/main/java/org/wso2/carbon/identity/provider/AttributeCallbackHandler.java >>> >>> Modified: >>> trunk/carbon/components/identity/org.wso2.carbon.identity.provider/src/main/java/org/wso2/carbon/identity/provider/AttributeCallbackHandler.java >>> URL: >>> http://wso2.org/svn/browse/wso2/trunk/carbon/components/identity/org.wso2.carbon.identity.provider/src/main/java/org/wso2/carbon/identity/provider/AttributeCallbackHandler.java?rev=118821&r1=118820&r2=118821&view=diff >>> >>> ============================================================================== >>> --- >>> trunk/carbon/components/identity/org.wso2.carbon.identity.provider/src/main/java/org/wso2/carbon/identity/provider/AttributeCallbackHandler.java >>> (original) >>> +++ >>> trunk/carbon/components/identity/org.wso2.carbon.identity.provider/src/main/java/org/wso2/carbon/identity/provider/AttributeCallbackHandler.java >>> Tue Jan 10 22:44:40 2012 >>> @@ -1,20 +1,20 @@ >>> -/* >>> -* Copyright (c) 2005-2010, WSO2 Inc. (http://www.wso2.org) All Rights >>> Reserved. >>> -* >>> -* WSO2 Inc. licenses this file to you under the Apache License, >>> -* Version 2.0 (the "License"); you may not use this file except >>> -* in compliance with the License. >>> -* You may obtain a copy of the License at >>> -* >>> -* http://www.apache.org/licenses/LICENSE-2.0 >>> -* >>> -* Unless required by applicable law or agreed to in writing, >>> -* software distributed under the License is distributed on an >>> -* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> -* KIND, either express or implied. See the License for the >>> -* specific language governing permissions and limitations >>> -* under the License. >>> -*/ >>> +/* >>> +* Copyright (c) 2005-2010, WSO2 Inc. (http://www.wso2.org) All Rights >>> Reserved. >>> +* >>> +* WSO2 Inc. licenses this file to you under the Apache License, >>> +* Version 2.0 (the "License"); you may not use this file except >>> +* in compliance with the License. >>> +* You may obtain a copy of the License at >>> +* >>> +* http://www.apache.org/licenses/LICENSE-2.0 >>> +* >>> +* Unless required by applicable law or agreed to in writing, >>> +* software distributed under the License is distributed on an >>> +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> +* KIND, either express or implied. See the License for the >>> +* specific language governing permissions and limitations >>> +* under the License. >>> +*/ >>> package org.wso2.carbon.identity.provider; >>> >>> import org.apache.axiom.om.OMElement; >>> @@ -236,8 +236,7 @@ >>> claimData.setValue(mapValues.get(claimData.getUri())); >>> if (claimData.getValue() != null) { >>> if >>> (RahasConstants.TOK_TYPE_SAML_20.equals(rahasData.getTokenType())) { >>> - saml2Attribute = >>> getSAML2Attribute(supportedClaims.get(claimData.getUri()) >>> - .getDisplayTag(), claimData.getValue(), >>> claimData.getUri()); >>> + saml2Attribute = >>> getSAML2Attribute(claimData.getUri(), claimData.getValue(), >>> claimData.getUri()); >>> callback.addAttributes(saml2Attribute); >>> } else { >>> attribute = new >>> SAMLAttribute(supportedClaims.get(claimData.getUri()) >>> _______________________________________________ >>> Carbon-commits mailing list >>> [email protected] >>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits >> >> >> >> >> -- >> Afkham Azeez >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> >> email: [email protected] cell: +94 77 3320919 >> blog: http://blog.afkham.org >> twitter: http://twitter.com/afkham_azeez >> linked-in: http://lk.linkedin.com/in/afkhamazeez >> >> Lean . Enterprise . Middleware >> >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> > > > > -- > Senaka Fernando > Product Manager - WSO2 Governance Registry; > Associate Technical Lead; WSO2 Inc.; http://wso2.com > Member; Apache Software Foundation; http://apache.org > > E-mail: senaka AT wso2.com > P: +1 408 754 7388; ext: 51736; M: +94 77 322 1818 > Linked-In: http://linkedin.com/in/senakafernando > > Lean . Enterprise . Middleware > -- Mobile : +94773330538 _______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
