These are the versions repeatedly defined in the componets/pom.xml

-        <wso2carbon.version>4.0.0-SNAPSHOT</wso2carbon.version>
-        <axis2.wso2.version>1.6.1.wso2v5</axis2.wso2.version>
-        <axis2.version>1.6.1-wso2v5</axis2.version>
-        <axis2.osgi.version.range>[1.6.1.wso2v1,
1.7.0)</axis2.osgi.version.range>
-        <axiom.osgi.version.range>[1.2.11.wso2v1,
1.3.0)</axiom.osgi.version.range>
-        <synapse.version>2.1.0-wso2v3</synapse.version>
-        <axiom.wso2.version>1.2.11.wso2v1</axiom.wso2.version>
-        <wsdl4j.wso2.version>1.6.2.wso2v2</wsdl4j.wso2.version>
-
<geronimo.stax.api.wso2.version>1.0.1.wso2v1</geronimo.stax.api.wso2.version>
-        <rampart.version>1.6.1-wso2v2</rampart.version>
-        <wss4j.version>1.5.11.wso2v1</wss4j.version>
-        <axis2-transports.version>1.1.0-wso2v4</axis2-transports.version>
-        <rampart.wso2.version>1.6.1.wso2v2</rampart.wso2.version>


These can be changed to

+        <wso2carbon.version>${carbon.platform.version}</wso2carbon.version>
+        <axis2.wso2.version>${orbit.version.axis2}</axis2.wso2.version>
+        <axis2.version>${version.axis2}</axis2.version>
+
<axis2.osgi.version.range>${imp.pkg.version.axis2}</axis2.osgi.version.range>
+
<axiom.osgi.version.range>${orbit.version.axiom}</axiom.osgi.version.range>
+        <synapse.version>${version.synapse}</synapse.version>
+        <axiom.wso2.version>${orbit.version.axiom}</axiom.wso2.version>
+        <wsdl4j.wso2.version>${orbit.version.wsdl4j}</wsdl4j.wso2.version>
+
<geronimo.stax.api.wso2.version>${orbit.version.geronimo-jms_1.1_spec}</geronimo.stax.api.wso2.version>
+        <rampart.version>${rampart.version}</rampart.version>
+        <wss4j.version>${orbit.version.wss4j}</wss4j.version>
+
<axis2-transports.version>${version.axis2.transport}</axis2-transports.version>
+
<rampart.wso2.version>${rampart.osgi.version}</rampart.wso2.version>

But, ideally, above properties should not be there in the
components/pom.xml. They can be referred from the platform pom. But if we
remove them now, we'll have to modify some componet poms.

Another thing I found is, same version is repeated in the platform pom. For
example,

<axis2.osgi.version>1.6.1.wso2v5</axis2.osgi.version>
<orbit.version.axis2>1.6.1.wso2v5</orbit.version.axis2>

 <rampart.version>1.6.1-wso2v3</rampart.version>
 <rampart.osgi.version>1.6.1.wso2v3</rampart.osgi.version>

There are few more.

Regards,
AmilaM.




On Mon, Jan 30, 2012 at 11:24 AM, Supun Malinga <sup...@wso2.com> wrote:

> Hi,
>
> On Mon, Jan 30, 2012 at 7:11 AM, Srinath Perera <srin...@wso2.com> wrote:
>
>> Jaggery guys please fix
>>
>>
>> Supun .. could you run a grep for >[0-9.]*.wso2*< and other similar
>> patterns to find other places we are not using  platform pom version
>> and send a report?
>>
>
> attached, result of, $ grep -r ">[0-9.]*.wso2*" . --include pom.xml
> this is excluding dependencies and the platform pom.
> Not all places need to be changed here. but there is quite a lot.
>
> thanks,
>
>>
>> We should do this time to time
>>
>> On Mon, Jan 30, 2012 at 1:50 AM, Supun Malinga <sup...@wso2.com> wrote:
>> > Hi devs,
>> >
>> > Please always try to use the platform pom defined versions. Below is
>> only
>> > some example of $subject. There is no need of redefining these
>> properties
>> > since its already defined in parent poms.
>> >
>> > ./components/jaggery/pom.xml:
>> >  <axis2.wso2.version>1.6.1.wso2v4</axis2.wso2.version>
>> > ./components/hostobjects/pom.xml:
>> >  <axis2.wso2.version>1.6.1.wso2v4</axis2.wso2.version>
>> > ./features/jaggery/pom.xml:
>> >  <axis2.wso2.version>1.6.1.wso2v4</axis2.wso2.version>
>> >
>> > Also similar redundant definitions are in components/pom.xml, etc.
>> > For eg: in components/pom.xml,
>> >         <wso2carbon.version>4.0.0-SNAPSHOT</wso2carbon.version>
>> >         <axis2.wso2.version>1.6.1.wso2v5</axis2.wso2.version>
>> >         <axis2.version>1.6.1-wso2v5</axis2.version>
>> >         <axis2.osgi.version.range>[1.6.1.wso2v1,
>> > 1.7.0)</axis2.osgi.version.range>
>> >         <axiom.osgi.version.range>[1.2.11.wso2v1,
>> > 1.3.0)</axiom.osgi.version.range>
>> >          ........
>> >
>> > These are already defined in the platform pom. So why are we redefining?
>> >
>> > thanks,
>> > --
>> > Supun Malinga,
>> >
>> > Software Engineer,
>> > WSO2 Inc.
>> > http://wso2.com
>> > http://wso2.org
>> > email - sup...@wso2.com
>> > mobile - 071 56 91 321
>> >
>> >
>> > _______________________________________________
>> > Carbon-dev mailing list
>> > Carbon-dev@wso2.org
>> > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>> >
>>
>>
>>
>> --
>> ============================
>> Srinath Perera, Ph.D.
>>    http://www.cs.indiana.edu/~hperera/
>>    http://srinathsview.blogspot.com/
>> _______________________________________________
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>
>
>
> --
> Supun Malinga,
>
> Software Engineer,
> WSO2 Inc.
> http://wso2.com
> http://wso2.org
> email - sup...@wso2.com <sup...@wso2.com>
> mobile - 071 56 91 321
>
>
> _______________________________________________
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
*Amila Maharachchi*
Senior Software Engineer; WSO2, Inc.; http://wso2.com

Blog: http://maharachchi.blogspot.com
Mobile: +94719371446
_______________________________________________
Carbon-dev mailing list
Carbon-dev@wso2.org
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to