Hi All, We had a review discussion on Carbon Authenticators and following are the review notes.
1. There are some common logic that should be implemented in every authenticator. Currently invoking this logic is duplicated among authenticators. So to avoid that we are planning to come up with an abstract Authenticator implementation. 2. As per now AuthenticationHandler first invokes AuthenticationAdmin and then it calls chain of authenticators. The AuthenticationAdmin call is not necessary. We need to refactor code in such a way that authenticator it self will only handle authenticating logic (Rather than within the Handler). 3. Properly implement authenticator chaining pattern. Make use “isHandle”, “priority”, “isAuthenticated” methods and make only authenticator aware about the logic. 4. After cleaning up the API, implement “Basic Auth” authenticator. (As first step) Thanks AmilaJ -- Mobile : +94773330538 _______________________________________________ Carbon-dev mailing list [email protected] http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
