Date: Monday, November 28, 2005 @ 14:52:00
Author: marc
Path: /cvsroot/carob/carob
Modified: include/CarobException.hpp (1.12 -> 1.13) src/CarobException.cpp
(1.8 -> 1.9)
Removed useless StackTraceElement copy constructor. Comments.
----------------------------+
include/CarobException.hpp | 12 ++++--------
src/CarobException.cpp | 9 ---------
2 files changed, 4 insertions(+), 17 deletions(-)
Index: carob/include/CarobException.hpp
diff -u carob/include/CarobException.hpp:1.12
carob/include/CarobException.hpp:1.13
--- carob/include/CarobException.hpp:1.12 Mon Nov 28 13:34:26 2005
+++ carob/include/CarobException.hpp Mon Nov 28 14:52:00 2005
@@ -291,9 +291,8 @@
* Map of the Java stack trace element contained in an exception
* (actually a CarobException)
*/
-class StackTraceElement
+struct StackTraceElement
{
-public:
/**
* Create a stacktrace element by deserialization from the given
* socket
@@ -302,12 +301,9 @@
*/
StackTraceElement(const DriverSocket& ds) throw (SocketIOException,
UnexpectedException);
- /**
- * Copy constructor
- */
- StackTraceElement(const StackTraceElement& st);
-public:
-// private: TODO: set them const?
+ // we would like to have const members (and initializer lists)
+ // but we would then rely on declaration order; plus there is
+ // a syntax issue with operator>>
wstring declaringClass;
wstring methodName;
wstring fileName;
Index: carob/src/CarobException.cpp
diff -u carob/src/CarobException.cpp:1.8 carob/src/CarobException.cpp:1.9
--- carob/src/CarobException.cpp:1.8 Fri Nov 25 16:10:58 2005
+++ carob/src/CarobException.cpp Mon Nov 28 14:52:00 2005
@@ -120,12 +120,3 @@
ds>>fileName;
ds>>lineNumber;
}
-
-// is this useful?
-StackTraceElement::StackTraceElement(const StackTraceElement& st)
-{
- declaringClass = st.declaringClass;
- methodName = st.methodName;
- fileName = st.fileName;
- lineNumber = st.lineNumber;
-}
_______________________________________________
Carob-commits mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/carob-commits
