Date: Friday, March 17, 2006 @ 12:46:49
  Author: marc
    Path: /cvsroot/carob/carob/include

Modified: Common.hpp (1.37 -> 1.38) DriverResultSet.hpp (1.37 -> 1.38)
          SQLDataSerialization.hpp (1.13 -> 1.14)

Enhanced comments about C99 (non-C++) intNN_t types


--------------------------+
 Common.hpp               |    5 -----
 DriverResultSet.hpp      |    2 +-
 SQLDataSerialization.hpp |   15 +++++++++++++--
 3 files changed, 14 insertions(+), 8 deletions(-)


Index: carob/include/Common.hpp
diff -u carob/include/Common.hpp:1.37 carob/include/Common.hpp:1.38
--- carob/include/Common.hpp:1.37       Fri Mar 17 10:16:53 2006
+++ carob/include/Common.hpp    Fri Mar 17 12:46:49 2006
@@ -26,11 +26,6 @@
 
 #include <string>
 
-// Uncomment to get definition of uint8_t etc. (needed with gcc<3.4 for 
instance)
-// #include <stdint.h>
-// or you can try this one:
-// #include <cstdint>
-
 #define   DEBUG_PRE  L"DEBUG:\t"
 #define   INFO_PRE  L"INFO:\t"
 #define   WARN_PRE  L"WARN:\t"
Index: carob/include/DriverResultSet.hpp
diff -u carob/include/DriverResultSet.hpp:1.37 
carob/include/DriverResultSet.hpp:1.38
--- carob/include/DriverResultSet.hpp:1.37      Mon Mar 13 19:20:21 2006
+++ carob/include/DriverResultSet.hpp   Fri Mar 17 12:46:49 2006
@@ -22,7 +22,7 @@
 #ifndef DRIVERRESULTSET_H_
 #define DRIVERRESULTSET_H_
 
-#include "SQLDataSerialization.hpp"
+#include "SQLDataSerialization.hpp" // brings C99 stdint.h (intNN_t, long long 
etc.)
 #include "CarobException.hpp"
 
 #include <vector>
Index: carob/include/SQLDataSerialization.hpp
diff -u carob/include/SQLDataSerialization.hpp:1.13 
carob/include/SQLDataSerialization.hpp:1.14
--- carob/include/SQLDataSerialization.hpp:1.13 Fri Feb 24 18:34:19 2006
+++ carob/include/SQLDataSerialization.hpp      Fri Mar 17 12:46:49 2006
@@ -22,12 +22,23 @@
 #ifndef SQLDATASERIALIZATION_H_
 #define SQLDATASERIALIZATION_H_
 
-#include <stdint.h> // for uint8_t, int32_t, uint32_t, int64_t, uint64_t
 
 #include "CarobException.hpp"
-
 #include "Common.hpp" // for java_byte: cannot forward declare typedefs
 
+
+#include <stdint.h> // for uint8_t, int32_t, uint32_t, int64_t, uint64_t
+// Alternative:
+// #include <cstdint>
+
+// Warning: this header and all the types it defines (including "long
+// long") are part of C99 and are MISSING from C++98.
+
+// See:
+// - "Incompatibilities Between ISO C and ISO C++" - David R. Tribble
+// - C++ Technical Report 1 (TR1)
+
+
 namespace CarobNS {
 
 class TypeTag;

_______________________________________________
Carob-commits mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/carob-commits

Reply via email to