Date: Thursday, February 15, 2007 @ 10:37:50
Author: gilles
Path: /cvsroot/carob/carob
Modified: include/Statement.hpp (1.43 -> 1.44) src/Statement.cpp (1.34 ->
1.35)
Removed second (double) trimming of queries in protected Statement.executeXXX
methods: request skeleton is already trimmed by caller (ie. public methods in
.hpp)
Enriched javadoc with this info
Fixes CAROB-85
Somehow related to performance issue CAROB-127
-----------------------+
include/Statement.hpp | 6 +++---
src/Statement.cpp | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
Index: carob/include/Statement.hpp
diff -u carob/include/Statement.hpp:1.43 carob/include/Statement.hpp:1.44
--- carob/include/Statement.hpp:1.43 Wed Jul 5 09:26:05 2006
+++ carob/include/Statement.hpp Thu Feb 15 10:37:50 2007
@@ -340,7 +340,7 @@
/**
* Convenience method for derived class ParameterStatement
- * @param skeleton SQL skeleton statement
+ * @param skeleton trimmed SQL skeleton statement
* @param parameters SQL parameters serialized into a string
* @return true if the result is a ResultSet or false if it is an integer
*/
@@ -351,7 +351,7 @@
NotImplementedException,
UnexpectedException);
/**
* Convenience method for derived class ParameterStatement
- * @param skeleton SQL skeleton statement
+ * @param skeleton trimmed SQL skeleton statement
* @param parameters SQL parameters serialized into a string
* @return a ResulSet pointer that contains the data produced by the query
*/
@@ -363,7 +363,7 @@
/**
* Convenience method for derived class ParameterStatement
- * @param skeleton SQL skeleton statement
+ * @param skeleton trimmed SQL skeleton statement
* @param serializedParameters SQL parameters serialized into a string
* @return either a row count, or 0 for SQL commands
*/
Index: carob/src/Statement.cpp
diff -u carob/src/Statement.cpp:1.34 carob/src/Statement.cpp:1.35
--- carob/src/Statement.cpp:1.34 Thu Jan 25 16:56:57 2007
+++ carob/src/Statement.cpp Thu Feb 15 10:37:50 2007
@@ -109,7 +109,7 @@
}
// invalidate the last results
cleanUpResults();
- sql_request = trim(skeleton);
+ sql_request = skeleton;
RequestWithResultSetParameters request(sql_request);
request.setEscapeProcessing(escapeProcessing).setTimeoutInSeconds(timeout);
if (!parameters.empty())
@@ -135,7 +135,7 @@
}
// invalidate the last write result
cleanUpResults();
- sql_request = trim(skeleton);
+ sql_request = skeleton;
RequestWithResultSetParameters request(sql_request);
request.setEscapeProcessing(escapeProcessing).setTimeoutInSeconds(timeout);
if (!parameters.empty())
@@ -165,7 +165,7 @@
throw DriverException(std::wstring(fctName)
+ L": unable to execute query on a closed statement");
}
- sql_request = trim(skeleton);
+ sql_request = skeleton;
cleanUpResults();
Request request(sql_request);
request.setEscapeProcessing(escapeProcessing).setTimeoutInSeconds(timeout);
_______________________________________________
Carob-commits mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/carob-commits
