I was looking at the changes in HttpClient slated for version 3.3.3 and I like the idea of doing the single log out HTTP calls asynchronously because there is a performance monitoring benchmark running against the site I support that over-emphasizes logout performance. I haven't played with the ExecutorService but they seem to have a shutdown method and this one isn't being called anywhere. I know webapps often suffer from classloader memory leaks and if something prevents the classloader from being garbage collected after a hot-deploy I worry that maybe the threads in the ExecutorService's associated thread pool might hang around along with the classes (since it is stored in static variable). At a minimum it might be worth exposing a static shutdown method so that it could be called in an application listener (on undeploy). On the subject of HttpClient, I would like to request that isValidEndPoint() method log the URL being invoked when an IOException is caught. I am currently getting socket exceptions and it would be nice to be able to turn on debug logging and see which URL they go with. I know this method is used to pass proxy granting tickets to other apps and those might not be something you would want to show up in a log file so if the parameters are excluded that is fine. Also, it could be logged at the debug level so that people could turn it off if they don't want to see it.
I am also using the JPATicketRegistry with Oracle and getting lots of deadlock detected exceptions in the logs. We customized the webapp to handle the errors and there doesn't seem to be performance penalty b/c Oracle detects the problem quickly, but it is nice to see that get fixed. I am looking forward to the 3.3.3 release. Thanks, Hal -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
