> There appear to be changes in the patch/fix unrelated to the fix itself.
In typical fashion I painted in broad strokes. > Can you create a patch without those changes? Will do by Monday midday. > I'd rather us debate the merits of the patch (of which I don't think there > will be any debate) rather than whether we should short-circuit if statements > or use named queries. Fair enough. My style of writing if statements is sincerely force of habit due to using checkstyle more often than not. The use of named queries seemed a natural improvement that presented itself due to the switch to pure JPA style queries. That said, it's best to focus on the least number of changes in this case. M -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
