I had thought about that as a solution as it would have been easier to code then what I did, that works great for the default value but wouldn't serve the needs of changing themes in the service manager.
Second that solution would require that the deployer creates a theme version of every view page, the solution we're using degrades gracefully so that if there isn't a theme version declared for any view the default is used instead. Andrew Petro and I looked over the code during the unconference and we both see a philosophical issue with the solution in that a JSP page is performing the logic of rendering the default view or the theme view. Andrew is going to look at the theme resolver to see if it can be enhanced to have a default theme fall back for base theme. -Andrew On Nov 10, 2011, at 5:10 PM, Jacob Lichner wrote: > That's probably the best way to do it for 3.4.11. Thanks for sharing! > > For 3.5, I'm wondering if we can get the views to resolve along with the > theme. > > If we establish a simple convention for the theme and view property files > such as: > > [theme_name]_theme.properties > [theme_name]_views.properties > > For example: > > default_theme.properties > default_views.properties > > Then both the views and the theme would have a common link (the theme name). > > # cas.properties > cas.themeResolver.defaultThemeName=default_theme > cas.viewResolver.basename=default_views > > From here we could append the "_views" and "_theme" to each value behind the > scenes. So, now we have: > > cas.themeResolver.defaultThemeName=default > cas.viewResolver.basename=default > > Then from here, we could resolve the value of the viewResolver entirely > behind the scenes by simply setting it to the same value as the > themeResolver, so that we are now left with a single property that both > resolves the theme and the views: > > cas.themeResolver.defaultThemeName=default > > Thoughts? > > > > On Nov 7, 2011, at 2:21 PM, Tillinghast, Andrew P. wrote: > >> The message that I sent explaining how we did theming is at >> https://lists.wisc.edu/read/messages?id=15317099#15317099 >> >> I'm at the Ja-Sig unconference and I was planning to try showing the theming >> solution we're using to either Andrew Petro or Bill Thompson. >> >> >> -Andrew >> >> On Nov 7, 2011, at 4:14 PM, Jacob Lichner wrote: >> >>> Andrew, you said you sent an email explaining it, was that email on the >>> mailing list? I might've missed it, I just recently subscribed. But I'm >>> definitely interested in taking a look at what you've done. >>> >>> Jacob >>> >>> Unicon Inc, UX >>> >>> On Oct 25, 2011, at 1:45 PM, Tillinghast, Andrew P. wrote: >>> >>>> >>>> If there is an effort to improve the skinning I'd like to suggest looking >>>> at the theming we've done at connecticut college (I sent an email >>>> explaining it) this change allows for service manager controlled themes >>>> that change the JSP source as well as the CSS. >>>> >>>> -Andrew >>>> >>>> On Oct 25, 2011, at 2:32 PM, Andrew Petro wrote: >>>> >>>>> CAS developers, >>>>> >>>>> I updated the roadmap just now >>>>> >>>>> https://wiki.jasig.org/display/CAS/CAS+Roadmap >>>>> >>>>> https://wiki.jasig.org/display/CAS/CAS+Roadmap#CASRoadmap-Improvedskinnability >>>>> >>>>> to note that the jump from CAS 3.4 to 3.5 is an opportunity to evolve CAS >>>>> skinning. There's a developer at Unicon passionate about taking a shot >>>>> at determining ways that skinning can be improved, Jacob Lichner -- and >>>>> since he's delivered a handful of CAS skins for some projects, I think he >>>>> may be able to recommend some ways to make that work simpler. >>>>> >>>>> Or not. >>>>> >>>>> I see the essence of the roadmap item to not let the version rev from 3.4 >>>>> to 3.5 to go unconsidered in terms of whether there are improvements to >>>>> skinning that should be made, not a commitment to re-invent CAS skinning >>>>> for the sake of re-inventing it. >>>>> >>>>> I don't know what the recommended improvements will be -- the work here >>>>> is to figure out whether and how this can be improved, by engaging >>>>> cas-dev@, by engaging #jasig-cas, by engaging cas-user@, and by trying it >>>>> and demonstrating some improvements. >>>>> >>>>> >>>>> Andrew >>>>> >>>>> -- >>>>> You are currently subscribed to [email protected] as: >>>>> [email protected] >>>>> To unsubscribe, change settings or access archives, see >>>>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >>>> >>> >> > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
