On Mon, Dec 5, 2011 at 8:49 PM, Scott Battaglia <scott.battag...@gmail.com> wrote: > Did you get an email of the comments on the original pull request?
Nope. > > Because if not, this could clearly explain the confusing conversation we're > having, ha! ah... > > > On Mon, Dec 5, 2011 at 8:44 PM, William G. Thompson, Jr. <wgt...@gmail.com> > wrote: >> >> Cool. Glad you have cycles to take a look. >> >> Bill >> >> >> On Mon, Dec 5, 2011 at 8:39 PM, Scott Battaglia >> <scott.battag...@gmail.com> wrote: >> > Ehcache, because that is the one I promised to code review right now :-D >> > >> > >> > On Mon, Dec 5, 2011 at 8:34 PM, William G. Thompson, Jr. >> > <wgt...@gmail.com> >> > wrote: >> >> >> >> Scott, are you talking about lppe or ehache? >> >> >> >> ehcahce was merged into master. >> >> >> >> lppe is still on the feature branch. >> >> >> >> Bill >> >> >> >> >> >> On Mon, Dec 5, 2011 at 6:47 PM, William G. Thompson, Jr. >> >> <wgt...@gmail.com> wrote: >> >> > Not sure I follow... >> >> > >> >> > On Mon, Dec 5, 2011 at 5:47 PM, Scott Battaglia >> >> > <scott.battag...@gmail.com> wrote: >> >> >> I posted comments. It was not ready to be merged in. Unless there >> >> >> were >> >> >> changes between the original pull request and the code in master. >> >> >> >> >> >> Cheers, >> >> >> Scott >> >> >> >> >> >> >> >> >> On Mon, Dec 5, 2011 at 5:30 PM, William G. Thompson, Jr. >> >> >> <wgt...@gmail.com> >> >> >> wrote: >> >> >>> >> >> >>> On Mon, Dec 5, 2011 at 4:52 PM, Scott Battaglia >> >> >>> <scott.battag...@gmail.com> wrote: >> >> >>> > Was the contribution code reviewed before being pulled in to >> >> >>> > master? >> >> >>> >> >> >>> Yes, I looked it over before pulling into master. >> >> >>> >> >> >>> > >> >> >>> > I believe Marvin said he was going to code review it (and I'm >> >> >>> > willing to >> >> >>> > also if Marvin hasn't completed it yet). >> >> >>> >> >> >>> Great. >> >> >>> >> >> >>> Bill >> >> >>> >> >> >>> >> >> >>> >> >> >>> > >> >> >>> > >> >> >>> > On Mon, Dec 5, 2011 at 4:44 PM, William G. Thompson, Jr. >> >> >>> > <wgt...@gmail.com> >> >> >>> > wrote: >> >> >>> >> >> >> >>> >> Folks, >> >> >>> >> >> >> >>> >> FYI. feature-lppe branch as the latest from AndrewT. I also >> >> >>> >> pulled >> >> >>> >> in the ehcache module into master...looks like some of the test >> >> >>> >> code >> >> >>> >> might need to be moved around, but the code is looking pretty >> >> >>> >> good. >> >> >>> >> >> >> >>> >> Bill >> >> >>> >> >> >> >>> >> -- >> >> >>> >> You are currently subscribed to cas-dev@lists.jasig.org as: >> >> >>> >> scott.battag...@gmail.com >> >> >>> >> To unsubscribe, change settings or access archives, see >> >> >>> >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >>> > >> >> >>> > >> >> >>> > -- >> >> >>> > You are currently subscribed to cas-dev@lists.jasig.org as: >> >> >>> > wgt...@gmail.com >> >> >>> > To unsubscribe, change settings or access archives, see >> >> >>> > http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >>> >> >> >>> -- >> >> >>> You are currently subscribed to cas-dev@lists.jasig.org as: >> >> >>> scott.battag...@gmail.com >> >> >>> To unsubscribe, change settings or access archives, see >> >> >>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >>> >> >> >> >> >> >> -- >> >> >> You are currently subscribed to cas-dev@lists.jasig.org as: >> >> >> wgt...@gmail.com >> >> >> To unsubscribe, change settings or access archives, see >> >> >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >> >> -- >> >> You are currently subscribed to cas-dev@lists.jasig.org as: >> >> scott.battag...@gmail.com >> >> To unsubscribe, change settings or access archives, see >> >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> >> > >> > -- >> > You are currently subscribed to cas-dev@lists.jasig.org as: >> > wgt...@gmail.com >> > To unsubscribe, change settings or access archives, see >> > http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> -- >> You are currently subscribed to cas-dev@lists.jasig.org as: >> scott.battag...@gmail.com >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: wgt...@gmail.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
