Thanks Scott, I have created two Jira issues.
https://issues.jasig.org/browse/CASC-168 https://issues.jasig.org/browse/CASC-169 We're not developing with an IoC framework, so it's very convenient to be able to use a configuration option to make use of the custom response parsing. cheers, Karl On 8/12/2011 5:43 p.m., Scott Battaglia wrote: > All of the filters support injecting your own IoC framework (the > typical example is to configure the filter in Spring). That said, > I'll take a look, and see how much complexity it adds. > > Can you create to JIRA enhancement issues (one for each thing you've > created patches for) > > Cheers, > Scott > > > On Sun, Dec 4, 2011 at 5:31 PM, Karl von Randow <k...@cactuslab.com > <mailto:k...@cactuslab.com>> wrote: > > We have a server that returns custom fields in the response that > we would like to parse out by overriding customParseResponse in > the Cas20ServiceTicketValidator. > > We couldn't find a way to create a custom subclass of > Cas20ServiceTicketValidator in > Cas20ProxyReceivingTicketValidationFilter so we've prepared a > patch to allow a new init-param to specify a custom implementation > class. > > Also in Cas20ServiceTicketValidator, if there are no custom > attributes in extractCustomAttributes it returns a > Collections.emptyMap(), which is immutable. So I explored changing > this to returning an empty HashMap so that a customParseResponse > implementation could always add to the existing attributes (even > if empty). > > I have attached a patch. I hope this is useful. > > Best regards, > Karl > -- > You are currently subscribed to cas-dev@lists.jasig.org > <mailto:cas-dev@lists.jasig.org> as: scott.battag...@gmail.com > <mailto:scott.battag...@gmail.com> > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > > -- > You are currently subscribed tocas-...@lists.jasig.org > <mailto:cas-dev@lists.jasig.org> as: k...@cactuslab.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
