Folks,
I have created the following pull request: https://github.com/Jasig/cas/pull/28 to address the JIRA ticket CAS-1083 [1]. The change proposes to eliminate the "evaluationOrder" property of a registered service in favor of implicit registration. I have managed to employ the existing ANTLR library to compare patterns to determine the level of strictness, while of course trying to minimize the API changes as much as possible. Specifically, this includes using the Comparator [2] that is provided by the AntPathMatcher class to determine the evaluation order of services. The change includes a series of unit tests that exhaust the evaluation mechanism to some degree. Additionally, to help with performance the code maintains a separate list of services that are sorted by evaluation order and this list is only updated when services are loaded, saved or removed (which I suppose are operations that are far less frequent than ticket granting requests) and In comparison with the existing code, this is done so that the evaluation logic is not done for every service lookup. Finally, services on the management UI are sorted by their evaluation order so the user can immediately follow the sequence. Please review. Regards, -Misagh [1] - https://issues.jasig.org/browse/CAS-1083 [2] - http://static.springsource.org/spring/docs/3.0.x/javadoc-api/org/springfra mework/util/AntPathMatcher.html#getPatternComparator(java.lang.String) -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
