Told you to stay tuned :) Yesterday i managed to get a successful authentication using Smart OpenId mode.
I already refactored some of my code. I also refactored the preivous dumb mode code, which i expect not to be working anymore (i would be surprised if it did). So i know have to adapt the dumb mode code to make it work along with the smart mode one, which will not be very hard. I introduced a dependency on the openid4java lib to the cas-server-support-openid. It would be useless and strange to reimplement methods provided by this lib (signing, generating a response, etc...). Of course i'll have to fix tests and add some more. I'll keep you informed of the progress. Frederic On Wed, Apr 11, 2012 at 1:48 PM, Frederic Esnault < esnault.frede...@gmail.com> wrote: > Thanks for the answer Bill. > I'm quite confident that i can finish the implementation/unit > test/refactor before may 4th. > Of course i'll try to finish sooner, but i won't push my changes before > i'm happy with the architecture and confident about the spec implementation > and it's test coverage. > I'll let you all informed, so stay tuned :) > > Frederic > > > On Wed, Apr 11, 2012 at 1:31 PM, William G. Thompson, Jr. < > wgt...@gmail.com> wrote: > >> > So as i'm not yet done, and given the code review needed, i'm wondering >> if >> > it can make it into the 3.5.RC1, and if yes, what would be the deadline >> for >> > the pull request to be issued? >> >> The sooner the better! :) >> >> Given your description of the changes, perhaps a week would be >> reasonable? May 4th for the pull request? May 11th is the RC1 >> deadline. >> >> Bill >> >> >> >> >> On Wed, Apr 11, 2012 at 4:09 AM, Frederic Esnault >> <esnault.frede...@gmail.com> wrote: >> > Hi all, >> > >> > I saw the planning for the releases of CAS 3.5 (RC1 and RELEASE). >> > I was wondering what was the deadline for a pull request, about the >> > implementation of OpenId Smart mode. >> > I'm working on it currently, most of it being done. I'm facing a >> problem of >> > a signature check failure at the end of the process, which is perfectly >> > normal as the association handle is not the same. I still have a bit of >> work >> > to sign correctly CAS requests. >> > After that i'd like to perform a little bit of refactoring, and of >> course >> > unit test my components. >> > I also introduced a DelegatingController (similar to spring security or >> > spring mvc delegating components), using a canHandle method to check if >> a >> > controller is able to handle a request. This was needed to allow >> differents >> > behavior to be mapped on the same url (/login). >> > The ServiceValidateController now implements a new interface >> > (DelegateController, defining the canHandle method), and implements it >> by >> > answering true. >> > This allows this kind of mapping (simplified xml) : >> > >> > <util:list id="delegates"> >> > <entry key="smartOpenIdController" ref="smartOpenIdController"/> >> > <entry key="serviceValidateContrller" >> ref="serviceValidateController"/> >> > </util:list> >> > >> > <bean id="delegatingController" class="o.j.c.w.DelegatingController"> >> > <property name="delegates" ref="delegates"/> >> > </bean> >> > >> > And the following handler mapping : >> > >> > <prop key="/login">delegatingController</prop> >> > >> > >> > This is a small refactoring of CAS infrastructure, and do not break >> usual >> > behavior but will need a code review on your side to be approved (or >> > rejected). >> > >> > So as i'm not yet done, and given the code review needed, i'm wondering >> if >> > it can make it into the 3.5.RC1, and if yes, what would be the deadline >> for >> > the pull request to be issued? >> > >> > Frederic >> > >> > -- >> > You are currently subscribed to cas-dev@lists.jasig.org as: >> wgt...@gmail.com >> > To unsubscribe, change settings or access archives, see >> > http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> -- >> You are currently subscribed to cas-dev@lists.jasig.org as: >> esnault.frede...@gmail.com >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> >> > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
