Plus it requires us to be disciplined about making sure to generate toString methods (and also then about avoiding ToStringBuilder's reflection methods ;-))
On Tue, Jul 17, 2012 at 10:00 AM, Marvin Addison <marvin.addi...@gmail.com>wrote: > > Okay, this assumes that there is no heavy cost in the construction of the > > parameters passed in. We should continue to be careful about using the > > check *if* the cost of the parameters is heavy (i.e .more than just > moving > > string concatenation to using the message formatter). > > That's a good point and exactly what I had in mind when I said > "disciplined use." We should discuss this consideration in some depth > on the coding conventions page. I'd like to recommend a simple > convention: simply pass whole objects as logging parameters and rely > on the toString method to provide a suitable string representation. > That provides for clean logging statements in application code, avoids > large string building costs if the logging level check is false, and > separates concerns nicely. > > M > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > scott.battag...@gmail.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
