Hi,

To be straightforward, I've always find pretty convenient the way things
work on this. I'm not sure to understand what benefits you except from this
change : do you have a use case in mind that could enlight me / us ?
Thanks.
Best regards,
Jérôme



2013/9/12 Misagh Moayyed <mmoay...@unicon.net>

> Team,
> Started to evaluate the feasibility of implementing CAS-1312:
> https://issues.jasig.org/browse/CAS-1312
>
> Currently, ticket id generators [for services] are looked up by name from
> a map, particularly by class name. This implies of course that as service
> extensions are developed, corresponding generators need to be added to this
> map. I was thinking to remove this dependency, by allowing each service
> type [CAS, Saml, etc] to define its own ticket id generator based on the
> current configuration, so that we might be able to define something like:
> service.getTicketIdGenerator(), and remove the need for the lookup.
>
> The caveat is that, in order to inject settings into ticket id generators
> some refactoring needs to be done so that settings such as maxLength and
> suffix are passed along to the right argument extractor, that is
> responsible for creating the service instance...or perhaps instead of
> injecting settings, we'll "set" the id generator instance as a whole for
> the service by passing it to the argument extractor directly. This latter
> approach is cleaner IMO, and allows also for defining alternative
> implementations of the id generator to be set on the service. Plus, better
> to pass the entire object as a whole, rather than individual pieces that
> construct it.
>
> What are your thoughts on this JIRA and options above?
>
> Misagh
>
> --
> You are currently subscribed to cas-dev@lists.jasig.org as: lel...@gmail.com
> To unsubscribe, change settings or access archives, see 
> http://www.ja-sig.org/wiki/display/JSG/cas-dev
>
>

-- 
You are currently subscribed to cas-dev@lists.jasig.org as: 
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to