And so it is done: https://issues.jasig.org/browse/CAS-1378 https://github.com/Jasig/cas/pull/353
Best regards, /Fredrik 28 okt 2013 kl. 22:29 skrev Fredrik Jönsson <[email protected]<mailto:[email protected]>>: Yes, I’ll look into that tomorrow. Regards, /Fredrik 28 okt 2013 kl. 21:57 skrev Misagh Moayyed <[email protected]<mailto:[email protected]>>: I think that is a good proposition and also has low impact on existing clients who may have not configured the particular username attribute (The default would work just as it did before). Would you be able to file a JIRA? If you could, a corresponding pull request would be great too :) -Misagh ________________________________ From: "Fredrik Jönsson" <[email protected]<mailto:[email protected]>> To: [email protected]<mailto:[email protected]> Sent: Monday, October 28, 2013 1:32:24 PM Subject: [cas-dev] Make CAS 1.0 validate respect username attribute in service registry? Hi, We have some old code in our CAS implementation which is essentially swapping out the username specified by the server with an internal user id we use throughout applications. I’m playing with CAS 4.0 RC2 and am very happy that I now can remove all this code and use built-in attribute mapping with service registry to achieve the same thing. However. The CAS 1.0 protocol does not respect the setting in the service registry. Since I’m afraid that we may actually have some old hacks that are using 1.0 validation, I still have to modify this view, but I wonder if this really shouldn’t be the default behavior? It is a minor change. Any thoughts? @@ -50,7 +51,7 @@ if (this.successResponse) { response.getWriter().print( "yes\n" - + assertion.getChainedAuthentications().get(0).getPrincipal() + + assertion.getPrimaryAuthentication().getPrincipal() .getId() + "\n"); } else { response.getWriter().print("no\n\n"); Best regards, /Fredrik -- Fredrik Jönsson, M.Sc. Email: [email protected]<mailto:[email protected]> System architect Phone: +46 8 790 66 03 Kungliga tekniska högskolan (KTH) Mobile: +46 73 595 66 03 KTH/UF/ITA/Infosys -- You are currently subscribed to [email protected]<mailto:[email protected]> as: [email protected]<mailto:[email protected]> To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected]<mailto:[email protected]> as: [email protected]<mailto:[email protected]> To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected]<mailto:[email protected]> as: [email protected]<mailto:[email protected]> To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
