Hi,

It really makes sense to allow the *DefaultTicketRegistryCleaner* to be
configurable for logout as the *LogoutManager* can be.
I consider it as a bug if we cannot disable logout in the registry cleaner
where as we can in the logout manager.
I'm +1 for merging this pull request for 4.0.
Best regards,
Jérôme




2014/1/22 John Gasper <jgas...@unicon.net>

>  Hi all,
>
> Misagh noticed that the DefaultTicketRegistryCleaner's property
> LogUserOutOfServices could benefit from externalizing its setting like was
> done with LogoutManager's disableSingleSignout property via
> "slo.callback.disabled". I told him that I could go ahead and implement the
> change.
>
> So I've opened CAS-1419 (https://issues.jasig.org/browse/CAS-1419) and
> made a pull request with the fix. You'll noticed that I used some Spring EL
> to invert the property since true enables SLO in the
> DefaultTicketRegCleaner's case but disables it in the LogoutManager's cas.
> Likewise a value of false disables SLO in the DefaultTicketRegCleaner and
> enables it in the LogoutManager.
>
> Hopefully that is helpful.
>
> John
>
> --
> You are currently subscribed to cas-dev@lists.jasig.org as: lel...@gmail.com
> To unsubscribe, change settings or access archives, see 
> http://www.ja-sig.org/wiki/display/JSG/cas-dev
>
>

-- 
You are currently subscribed to cas-dev@lists.jasig.org as: 
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to