On Thu, Nov 20, 2014 at 10:20 AM, Marvin Addison <marvin.addi...@gmail.com> wrote:
> <snip /> > My sense is that we're spending inordinate amounts of time discussing > relatively minor changes, and anything that touches on design becomes mired > in endless discussion. Here's a few current or recent issues that I thought > were symptomatic: > > https://github.com/Jasig/cas/issues/669 > https://github.com/Jasig/cas/pull/730 > https://github.com/Jasig/cas/issues/695 > > Extensive discussion for small changes is wasteful; we're a small team and > we don't have the resources to suffer inefficiency. > The issue is that we're not approaching this in a collaborative fashion. There are times where an issue gets put in and a pull request immediately or close to immediately follows. Therefore every comment looks confrontational or like wasteful commentary since someone already provided code. I'm not doing my job if I rubber stamp changes because someone provided code. My only opportunity at this point for collaboration is to tell you why I think you did it wrong or should have done it differently instead of us coming to a workable approach via conversation. I also have to now choose between just constantly commenting on other people's pull requests which sometimes come out of nowhere or being able to contribute my own code/ideas. This is frustrating for both the person trying to contribute code and the people also trying to contribute. Also, considering I had to go back and re-work/re-add a number of CAS Client APIs because people shipped "small changes" that broke backwards compatibility, conversation about changes is not wasteful. The question is considering our different timelines, time zones, priorities, and reason for involvement, what gives us the highest level of positive collaboration to move things along efficiently and keep everyone (mostly) happy :-) -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
