Is the MySQL complaint causing issues?


--Misagh



From: [email protected] [mailto:[email protected]] On Behalf Of Paul 
Mitchell
Sent: Friday, November 18, 2016 3:50 AM
To: CAS Community <[email protected]>
Subject: [cas-user] gauth-jpa



Hi,



I found what appears to be a bug in 
GoogleAuthenticatorRegistrationRecord.java the record contains the lines



 @Column(length = Integer.MAX_VALUE, updatable = true, insertable = true, 
nullable = false)



for two of the string fields in the class.  This causes Hibernate to 
generate the follow SQL:



  create table GoogleAuthenticatorRegistrationRecord (id bigint not null, 
secretKey varchar(2147483647) not null, username varchar(2147483647) not 
null, validationCode integer not null, primary key (id))



which naturally MySQL complains about the size of the varchar.  This was 
changed between RC4 and 5.0.0 with commit 'fe1155a'. Prior to the commit the 
length was 255.  There is also an integer field validationCode which also 
had a length of 255, which was changed to Integer.MAX_VALUE which to me make 
sense.



Can submit an issue/pull request with what I think it should be but wanted 
to check in if there was a good reason for this that I am not aware of.



Regards,

Paul.

-- 
- CAS gitter chatroom: https://gitter.im/apereo/cas
- CAS mailing list guidelines: 
https://apereo.github.io/cas/Mailing-Lists.html
- CAS documentation website: https://apereo.github.io/cas
- CAS project website: https://github.com/apereo/cas
--- 
You received this message because you are subscribed to the Google Groups 
"CAS Community" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to [email protected] 
<mailto:[email protected]> .
To view this discussion on the web visit 
https://groups.google.com/a/apereo.org/d/msgid/cas-user/f938e37b-4d90-4b05-bce1-5b317523bef8%40apereo.org
 
<https://groups.google.com/a/apereo.org/d/msgid/cas-user/f938e37b-4d90-4b05-bce1-5b317523bef8%40apereo.org?utm_medium=email&utm_source=footer>
 
.

-- 
- CAS gitter chatroom: https://gitter.im/apereo/cas
- CAS mailing list guidelines: https://apereo.github.io/cas/Mailing-Lists.html
- CAS documentation website: https://apereo.github.io/cas
- CAS project website: https://github.com/apereo/cas
--- 
You received this message because you are subscribed to the Google Groups "CAS 
Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/apereo.org/d/msgid/cas-user/00aa01d241aa%24e1b42110%24a51c6330%24%40unicon.net.

Reply via email to