Hi, Responses again in-line. On Mon, Sep 28, 2009 at 10:03 AM, Nicolas Boullis <[email protected]> wrote: [...] >> This sounds like a legitimate issue, I will look into this. > > Do you want me to send you my (trivial) patch?
Sure, please feel free to send any code directly to me or (preferably) create a JIRA issue with the pertinent information so it can be tracked and I don't forget about it. [...] > In my situation, this would be: > USER -> http://www.example.com/foo/index.html -> > http://internal.example.com:8001/index.html > > >> I think there might need to be 3 directives to appropriately handle >> this case: one to override the hostname (e.g. >> CASOverrideServiceHostname www.example.com), one to define whether the >> port should be printed(e.g. CASPrintServicePort Off/On/Default), and >> one to define the scheme (CASServiceScheme "https"). > > Why so many options? With my patch, I set > CASRootProxiedAs http://www.example.com/foo > and when I have to construct the URL, I prepend the content of the > CASRootProxiedAs option to the requested path, instead of constructing > the URL with the scheme, hostname (and port). Currently, the way that the service URL is constructed is using those 3 pieces of information (scheme, hostname and URI). My preference would be to still have them discretely available for consistency's sake, but if there are no significant advantages to that method then the CASRootProxiedAs approach might be more straightforward. I'm warming up to the idea of that as I think about it. Thanks, -Phil -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user
