Stephen, We're happy to accept any documentation help. Marvin's mostly leading that effort at the moment. At a minimum, if you can capture any errors you found and put them into a JIRA issue for our Documentation project, that would be great. I'll let Marvin speak to anything beyond that.
With regards to your specific question. We don't automatically associate an AttributeRepository with the resolver because there's ramifications of pulling in any attributes (they get stored with the principal) which we want to be a conscious decision (even if its just stub attributes). There's little harm in the Services Management holding a reference to the repository. That said, if we're not explicitly telling you in our documentation that you need to link the two when you decide you want to return attributes, then that's a problem and we should correct it. Cheers, Scott On Mon, Nov 29, 2010 at 5:17 PM, Stephen Todd <[email protected]>wrote: > Hi, > > I just went through implementing attribute release on 3.4.3 and there > were a few hitches I wanted to document at least through the mailing > list. I had set up the attribute repository but attributes were never > getting into the saml response. Skipping the steps I took to debug it, > it turns out that naming the attribute repository bean to > attributeRepository is not enough (as has been alluded to in the > comment above the attributeRepository bean in > deployerConfigContext.xml and several list emails). The missing step > was setting the attributeRepository property on the > CredentialsToPrincipalResolver. > > The directions for attribute release are a little confusing and > include unnecessary steps. It seems to me that all that really needs > to happen to do attribute release is get service management working > and configure the attribute repository. The current set up of the > CredentialsToPrincipalResolver seems like a bug to me. To me, it seems > that the bean should be declared this way by default: > > <bean > > > class="org.jasig.cas.authentication.principal.UsernamePasswordCredentialsToPrincipalResolver" > p:attributeRepository="attributeRepository"/> > > The presence of the default attributeRepository bean (class > StubPersonAttributeDao) is a little misleading otherwise. > > I'm willing to help on the attribute release page (and others), if desired. > > -Steve > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-user > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user
