On Mon, Jan 10, 2011 at 9:42 AM, Marvin Addison <[email protected]>wrote:
> > Any advice please on why this was done? I have no idea how it can run > with the session set to false given that casLoginView.jsp includes explicit > references to "sessionScope"...? > > Looks like a mistake to me. Here's the commit log for that change: > > It wasn't a mistake. It was changed and tested on Tomcat 6 and it worked fine. We don't test in other containers before a release typically. Upon reports of OOTB, Tomcat 5 having errors, we opened an issue for CAS 3.4.6 to revert the change. (I don't have the issue handy) The change was put in to ensure that sessions were only created as needed. Clearly that doesn't work in some containers. It also means that we really should be increasing the number of containers we test with before we release (which is going to be a pain). Cheers, Scott > r22360 | battags | 2010-11-14 21:49:26 -0500 (Sun, 14 Nov 2010) | 3 lines > Changed paths: > M > /cas3/branches/cas-3_4_x_maintenance/cas-server-3.4.2/cas-server-webapp/src/main/webapp/WEB-INF/view/jsp/default/ui/includes/top.jsp > M > /cas3/branches/cas-3_4_x_maintenance/cas-server-3.4.2/cas-server-webapp/src/main/webapp/WEB-INF/view/jsp/services/includes/top.jsp > > CAS-913 > > applied suggested improvements (moving doctype, removing non-needed > init method, and js file) > > I can only imagine that since it's a general header file that > session-less was chosen for the default since session is unneeded > except on login (for webflow state). I'm fairly certain > casLoginView.jsp should have session="true". > > What's puzzling is that no one has reported this problem. Most folks > deploy on Tomcat, so maybe it is more forgiving in creating a session > on demand? > > I'll let Scott weigh in on the change in r22360, but I expect we'll be > filing an issue to correct this. > > M > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-user > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-user
