Would love to get some feedback on https://issues.jasig.org/browse/CAS-1071

I'm strongly in favor of this change generally. As for the particular implementation that's mentioned on the issue via pull request, it looks good except for a small but important issue that I noted with an inline comment, https://github.com/mmoayyed/cas/commit/16a5a2d660a128dc554f0e95af370c0ad903e8cb.

M

--
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-user

Reply via email to