I've opened a JIRA for this issue: https://issues.jasig.org/browse/CAS-1294

I recommend that the previous behavior be restored by adding the url to the
compareTo method.

If service names are to become unique I would ask that be done only in
conjunction with CAS-1075 where an additional field for the "displayed
service name" (what is shown on the CAS login page) is added to the
database.
Thanks for your help,
-Michael
On Fri, Apr 12, 2013 at 11:35 AM, Scott Battaglia <[email protected]
> wrote:

> Its failing because of the compareTo:
>
> public int compareTo(final RegisteredService other) {
>
>         return new CompareToBuilder()
>
>                   .append(this.getEvaluationOrder(), 
> other.getEvaluationOrder())
>
>                   .append(this.getName().toLowerCase(), 
> other.getName().toLowerCase())
>
>                   .toComparison();
>
>     }
>
>
> In comparing to populate a treeset, its only considering evaluation order and 
> name.  If the name is the same and no evaluation order is specified it 
> considers them them the same.  It should add URL if we do not have a 
> uniqueness constraint on name.
>
>
> -Scott Battaglia
> PGP Public Key Id: 0x383733AA
> LinkedIn: http://www.linkedin.com/in/scottbattaglia
>
>
> On Fri, Apr 12, 2013 at 11:26 AM, Michael Herring <[email protected]>wrote:
>
>> I'll open a JIRA but would first like to know why service names ought to
>> be unique? I see no technical reason for this stipulation and it
>> complicates situations where a vendor provides multiple service urls for
>> different constituencies. We display the service name on our CAS login page
>> and want to keep it generic for all user groups. See my comments on
>> https://issues.jasig.org/browse/CAS-1075 for more information.
>>
>> Thanks,
>> -Michael
>>
>> On Fri, Apr 12, 2013 at 11:12 AM, Misagh Moayyed <[email protected]>wrote:
>>
>>>  Yes that does appear to be the case. Service names ought to be unique
>>> though. If you could open up a JIRA for this issue, I could take a look and
>>> see if we can enforce that condition. ****
>>>
>>> ** **
>>>
>>> *From:* Michael Herring [mailto:[email protected]]
>>> *Sent:* Friday, April 12, 2013 6:52 AM
>>> *To:* [email protected]
>>> *Subject:* Re:[cas-user] Service Manager differences between 3.4.12 and
>>> 3.5.x?****
>>>
>>> ** **
>>>
>>> Can anybody confirm this behaviour or weigh in on if it is expected?****
>>>
>>>  ****
>>>
>>> To test try adding the following service definitions *naming them 
>>> both*"App1":
>>> ****
>>>
>>> http://test.school.edu/app1/students****
>>>
>>> http://test.school.edu/app1/staff****
>>>
>>> After adding the services can you see them both from the Service
>>> Management Console (manage.html)?****
>>>
>>>  ****
>>>
>>> Thanks for your help,****
>>>
>>> -Michael****
>>>
>>> On Mon, Apr 8, 2013 at 3:53 PM, Michael Herring <[email protected]>
>>> wrote:****
>>>
>>> All,****
>>>
>>>  ****
>>>
>>> I'm working with CAS 3.5.2 and am experiencing different behavior with
>>> the services manager from CAS 3.4.12. We have multiple hosted services that
>>> have more than one service URL, one for each constituent group (students,
>>> staff, admins). In 3.4.12 we gave all of these service entries the same
>>> name (we display that on the CAS login page) and when we viewed the
>>> services manager I could see each entry. With 3.5.2 I only see one entry
>>> for each service name, unless I set an order. Is this expected? The "add
>>> new service" page does not enforce unique service names. Can anyone confirm
>>> this behavior?****
>>>
>>>  ****
>>>
>>> I'm using the DB (MySQL) to persist our service registry configured per:
>>> https://wiki.jasig.org/display/CASUM/Configuring****
>>>
>>>  ****
>>>
>>> I'm willing to open a Jira if this is a bug?****
>>>
>>>  ****
>>>
>>> Thanks for your help,****
>>>
>>> -Michael****
>>>
>>>  ****
>>>
>>> -- ****
>>>
>>> Michael Herring****
>>>
>>> Information Technology Services****
>>>
>>> Web Developer****
>>>
>>> Denison University****
>>>
>>> 740-587-6360****
>>>
>>> [email protected]****
>>>
>>>  ****
>>>
>>>
>>>
>>>
>>> -- ****
>>>
>>> Michael Herring
>>> Information Technology Services
>>> Web Developer
>>> Denison University
>>> 740-587-6360
>>> [email protected]****
>>>
>>> --
>>> You are currently subscribed to [email protected] as: 
>>> [email protected]
>>>
>>>
>>> To unsubscribe, change settings or access archives, see 
>>> http://www.ja-sig.org/wiki/display/JSG/cas-user****
>>>
>>>  --
>>> You are currently subscribed to [email protected] as: 
>>> [email protected]
>>>
>>>
>>> To unsubscribe, change settings or access archives, see 
>>> http://www.ja-sig.org/wiki/display/JSG/cas-user
>>>
>>>
>>
>>
>> --
>> Michael Herring
>> Information Technology Services
>> Web Developer
>> Denison University
>> 740-587-6360
>> [email protected]
>>
>> --
>>
>> You are currently subscribed to [email protected] as: 
>> [email protected]
>>
>>
>>
>> To unsubscribe, change settings or access archives, see 
>> http://www.ja-sig.org/wiki/display/JSG/cas-user
>>
>>
> --
> You are currently subscribed to [email protected] as: 
> [email protected]
> To unsubscribe, change settings or access archives, see 
> http://www.ja-sig.org/wiki/display/JSG/cas-user
>
>


-- 
Michael Herring
Information Technology Services
Web Developer
Denison University
740-587-6360
[email protected]

-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-user

Reply via email to