[
https://issues.apache.org/jira/browse/CASSANDRA-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695960#action_12695960
]
Jun Rao commented on CASSANDRA-52:
----------------------------------
I reviewed the patches. Overall, they look good. I got a couple of comments.
1. For tests like testTimeSort, it would be useful to add a test case where
data is stored in both memtable and sstables.
2. ant test seems to fail on testTimeSort (after data is flushed to SSTable).
However, when I stepped through the test in eclipse, it seemed to be ok. Not
sure if others have the same issue.
> Clean up SequenceFile.next to prep for partitioning refactor
> ------------------------------------------------------------
>
> Key: CASSANDRA-52
> URL: https://issues.apache.org/jira/browse/CASSANDRA-52
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Attachments:
> 0001-CASSANDRA-52-write-get_columns_since-test-to-exercise.txt,
> 0002-reformat-code-mostly-whitespace-changes-to-keep-subs.txt,
> 0003-r-m-no-op-seeks.txt,
> 0004-refactor-SF.next-String-key-DataOutputBuffer-bufOut.txt,
> 0005-semantics-of-TimeFilter-include-all-columns-newer-tha.txt,
> 0006-emphasize-that-when-getting-a-time-based-slice-only-th.txt,
> 0007-merge-common-parts-of-next-timeRange-and-next-columnN.txt,
> 0008-combine-next-getData-overloads.txt,
> 0009-combine-overloads-of-SSTable.next-inline-getData.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
