[
https://issues.apache.org/jira/browse/CASSANDRA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698878#action_12698878
]
Eric Evans commented on CASSANDRA-37:
-------------------------------------
The only nit I have is that in SSTable, dataFile_ has been made implicitly
public in order to make it accessible from SSTableTest. Perhaps it would be
better to keep it private and use a getter instead?
Other than that, +1
> Remove JDK-derived code from project
> ------------------------------------
>
> Key: CASSANDRA-37
> URL: https://issues.apache.org/jira/browse/CASSANDRA-37
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 0.3
>
> Attachments:
> 0001-add-SSTable-tests.-in-particular-we-want-to-be-sure.patch,
> 0002-r-m-copied-JDK-code.patch, 37.tgz
>
>
> Some classes appear to have been copied from the JDK source and altered to
> improve them for use in Cassandra. Unfortunately neither the classic JDK nor
> the OpenJDK license is compatible with the Apache license that Cassandra is
> operating under. See https://issues.apache.org/jira/browse/LEGAL-46
> Modified JDK classes include:
> - BitSet [JDK: BitSet]
> - FastByteArrayInputStream [ByteArrayInputStream]
> - FastByteArrayOutputStream [ByteArrayOutputStream]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
