[
https://issues.apache.org/jira/browse/CASSANDRA-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699256#action_12699256
]
Jonathan Ellis commented on CASSANDRA-81:
-----------------------------------------
functionality patch looks ok. (but watch bracing -- }else should be two lines
to be consistent. I can fix that up on apply though in this case.)
some comments on the tests --
1. does testGetRowSingleColumn add anything, coverage-wise? If not, I don't
want to maintain it. :)
2. don't catch test exceptions, let them get raised. that's a lot more
informative than assertTrue(False).
3. table.clearSnapshot() is a no-op here, so leave that out. (if you inherit
from ServerTest that will do a slightly better job of cleanup but the code
relies too much on static structures for us to do it "right." so don't worry
too much about that.)
> get_slice ignores the "start" parameter
> ---------------------------------------
>
> Key: CASSANDRA-81
> URL: https://issues.apache.org/jira/browse/CASSANDRA-81
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: fix_for_get_slice.patch, unit_tests_for_get_slice.patch
>
>
> get_slice(string tablename, string key, string columnFamily_column, i32
> start, i32 count) is expected is return all columns starting at offset
> "start" subject to a maximum of "count" columns. The current code does not do
> this.
> Example interaction:
> ./Cassandra-remote insert 'Table1' 'key' 'DATA:c1' 'val1' 1
> None
> ./Cassandra-remote insert 'Table1' 'key' 'DATA:c2' 'val2' 1
> None
> ./Cassandra-remote insert 'Table1' 'key' 'DATA:c3' 'val3' 1
> None
> ./Cassandra-remote get_slice 'Table1' 'key' 'DATA' 0 2
> [ {'columnName': 'c1', 'value': 'val1', 'timestamp': 1},
> {'columnName': 'c2', 'value': 'val2', 'timestamp': 1}]
> ./Cassandra-remote get_slice 'Table1' 'key' 'DATA' 1 2
> [ {'columnName': 'c1', 'value': 'val1', 'timestamp': 1},
> {'columnName': 'c2', 'value': 'val2', 'timestamp': 1}]] <<---- Same as
> prev! "start" ignored
> ./Cassandra-remote get_slice 'Table1' 'key' 'DATA' 0 1
> [{'columnName': 'c1', 'value': 'val1', 'timestamp': 1}]
> ./Cassandra-remote get_slice 'Table1' 'key' 'DATA' 2 1
> [{'columnName': 'c1', 'value': 'val1', 'timestamp': 1}] <<---- Same as
> prev! "start" ignored
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
