[
https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699910#action_12699910
]
Sandeep Tata commented on CASSANDRA-85:
---------------------------------------
Looks good. All tests pass.
+1 on the added tests and the forceBlockingFlush
I'm not sure I see the advantage of switching to using a static method in
ColumnFamilyStore.getColumnFamilyStore() as a factory method and leaving a
package scoped constructor that is only used in this static method.
-1 on this.
For the future, perhaps it'll be easier if we separated cleanup/refactoring and
adding unit tests into separate tickets? I understand that sometimes adding a
test needs you to do some refactoring, but smaller, focused patches make for
easier and quicker review :)
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments:
> 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt,
> 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt,
> 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt,
> 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing
> an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
