[ 
https://issues.apache.org/jira/browse/CASSANDRA-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716453#action_12716453
 ] 

Jun Rao commented on CASSANDRA-208:
-----------------------------------

Some comments:
1. In SSTable.loadIndexFile, indexEntries could be empty if there are fewer 
than indexInterval keys. I don't see code dealing with empty indexEntries. A 
simple solution is to add the last index key to indexEntries when indexEntries 
is empty. Similarly, you have to fix the same case when an SSTable is first 
created. You have to remember the last index key being appended.

2. In SSTable.next, need to deal with the case that getPosition() returns -1. 

3. In SSTable.getColumnGroupReader, change getNearestPostion() to getPostion(). 
Similar to 2, need to deal with returned position being -1.


Also, we need to remember opening another issue to get rid of partitioner from 
KeyPosition.



> OOM intermittently during compaction
> ------------------------------------
>
>                 Key: CASSANDRA-208
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-208
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: arch: x86_64
> os: Linux version 2.6.18-92.1.22.el5 
> java: nio2-ea-bin-b99-linux-x64-05_feb_2009
>            Reporter: Jiansheng Huang
>            Assignee: Jonathan Ellis
>            Priority: Critical
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-208-cleanup.txt, 0002-r-m-touch.txt, 
> 0003-split-sstable-into-data-index-and-bloom-filter-files.txt
>
>
> jvm crashes intermittently during compaction. Our test data set is not that 
> big, less than 10 GB.
> When jvm is about to crash, we see that it consumes a lot of memory 
> (exceeding the max heap size).
> The excessive memory usage during compaction is caused by the maintenance of 
> blockIndexes_ in SSTable. this blockIndexes_ was only introduced to the 
> apache version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to