[
https://issues.apache.org/jira/browse/CASSANDRA-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721885#action_12721885
]
Jun Rao commented on CASSANDRA-237:
-----------------------------------
Looked at the patch. It looks fine overall. A few comments:
1. In CL.maybeUpdateHeader(), why are there 2 identical if tests?
2. In CL.discard(), the following should never happen. Otherwise, the recovery
logic won't be right. So, we probably should change the if test to as assertion.
if ( cLogCtx.position < commitLogHeader.getPosition(id) )
3. This is an optimization and should be left to another jira if we want to
pursue this. I don't quite understand why a new CL has to inherit the dirty
bits from the old one. If during the lifetime of a CL, a CF is not updated, its
bit can be left off. This allows CLs to be GCed early.
> test and cleanup CommitLogHeader
> --------------------------------
>
> Key: CASSANDRA-237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-237
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-237-add-CommitLog-test.txt,
> 0002-add-log-replay-test.txt,
> 0003-update-comments-perform-some-renames-r-m-unused-code.txt,
> 0004-switch-from-byte-to-BitSet-in-CommitLogHeader.txt,
> 0005-fix-serialization-bugs-in-bitset-patch.txt
>
>
> patches 01, 02, and 03 that I created for CASSANDRA-79 apply here and can be
> reviewed separately.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
