[ 
https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722260#action_12722260
 ] 

Jonathan Ellis commented on CASSANDRA-243:
------------------------------------------

This makes fixes (1) and (2) suggested by Jun.

It is better to leave (3) alone though.  Added comment:

            // we leave the old 'dirty' bits alone, so we can test for
            // whether it's safe to remove a given log segment by and-ing its 
dirty
            // with the current one.
 
testing with and() is going to be a lot faster than iterating through the bits 
one by one.  premature optimization, perhaps, but harmless at this point.

> more commitlogheader improvement
> --------------------------------
>
>                 Key: CASSANDRA-243
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-243
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to