[ 
https://issues.apache.org/jira/browse/CASSANDRA-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726249#action_12726249
 ] 

Jun Rao commented on CASSANDRA-259:
-----------------------------------

Some minor comments:
1. Need to make it clear that the new config para keyCacheSize is in percentage 
of # of keys. Change it to keyCacheSizeInPCT?
2. Make SSTable an abstract class.

The bigger questions:  Do we plan to cache the column values themselves at CFS 
level? This seems to be the more effective caching mechanism. Will caching at 
CFS level obviate the need for caching key positions or do we want to support 
caching in multiple levels?

> LRU cache for key positions
> ---------------------------
>
>                 Key: CASSANDRA-259
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-259
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 
> 0001-CASSANDRA-259-encapsulate-bloom-filter-access-into-sst.txt, 
> 0002-add-concurrentlinkedhashmap-cache-and-config-option.txt, 
> 0003-refactor-sstable-into-SSTable-SSTableReader-and-SSTa.txt, 
> 0004-per-table-cache-size.txt
>
>
> add cache like the old touch cache, but working :)
> this will mitigate the performance hit from CASSANDRA-223

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to