[ 
https://issues.apache.org/jira/browse/CASSANDRA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arin Sarkissian updated CASSANDRA-276:
--------------------------------------

    Attachment: jbellis-comments.patch

Here's a patch with the comments from Jonathan Ellis.

There were zero usages for DD.getDataFileLocationForTable() so i renamed I 
renamed DD.getCompactionFileLocationForTable() to 
DD.getDataFileLocationForTable()

Also removed DD.getDataFileLocation() because it was never used

re: the indexoutofbounds possibility in getDataFileLocationForTable():
the call to getAllDataFileLocationsForTable(table) essentially just loops over 
dataFileDirectories_ and appends the table name as you suggested.



> use subdirectory-per-table for data files
> -----------------------------------------
>
>                 Key: CASSANDRA-276
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-276
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Arin Sarkissian
>         Attachments: 0001-changes.patch, 
> 0001-cleanup-the-patch-for-a-second-round.patch, 
> 0001-Single-pacth-for-Cassandra-276.patch, 
> 0002-Cassandra-276-no-WS-Diff.patch, jbellis-comments.patch
>
>
> it's a little silly to do this in the filename when the FS will give us a 
> heirarchical structure for free.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to