[ 
https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736967#action_12736967
 ] 

Michael Greene commented on CASSANDRA-111:
------------------------------------------

with a trunk cassandra-crlf and a patched cassandra-crlf2 this returns no 
result:
diff -r -w cassandra-crlf cassandra-crlf2

+1 for applying this immediately.  There are no enormous patches in the queue 
and this doesn't mess with any Windows-specific files.

I still think we should be applying the svn properties and configuration I 
discuss above, but getting all the files into the correct format is the most 
important step.

> Mixed line endings in the codebase
> ----------------------------------
>
>                 Key: CASSANDRA-111
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-111
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jeff Hodges
>         Attachments: 
> 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 
> 0001-unix-line-endings-on-799140.patch, line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS 
> line endings. Some files are even mixes of DOS and Unix line endings. This 
> patch removes all the DOS file endings and corrects them to Unix.
> Also attached is the program that I used to remove them. 
> Using Unix line endings in all places makes lots of things easier. At the 
> very least, a consistent choice of line endings would. Has there been 
> discussion of what should be the correct line ending to use?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to