[
https://issues.apache.org/jira/browse/CASSANDRA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738530#action_12738530
]
Jonathan Ellis commented on CASSANDRA-335:
------------------------------------------
> Is calling fileIndexGenerator_ twice supposed to be an atomic op, or can it
> be interleaved?
only one thread calls it, so this is immaterial.
> make the code's intent to incr twice clear; current getTempSSTablePath looks
> like a bug
done this morning as part of the 213 patch series
> Temp SSTable Generation increases by two, instead of one
> --------------------------------------------------------
>
> Key: CASSANDRA-335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-335
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Chris Goffinet
> Priority: Trivial
> Fix For: 0.4
>
> Attachments: CASSANDRA-335.patch
>
>
> String getTempSSTableFileName()
> {
> fileIndexGenerator_.incrementAndGet();
> return String.format("%s-%s-%s-Data.db",
> columnFamily_, SSTable.TEMPFILE_MARKER,
> fileIndexGenerator_.incrementAndGet());
> }
> It's incrementing twice. Remove the first one since the return is already
> calling it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
