[
https://issues.apache.org/jira/browse/CASSANDRA-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741361#action_12741361
]
Jonathan Ellis commented on CASSANDRA-241:
------------------------------------------
can you add boolean sanity checking like this?
String syncRaw = xmlUtils.getNodeValue("/Storage/CommitLogSync");
if (!"false".equals(syncRaw) && !"true".equals(syncRaw))
{
// Bool.valueOf will silently assume false for values it
doesn't recognize
throw new ConfigurationException("Unrecognized value for
CommitLogSync. Use 'true' or 'false'.");
}
commitLogSync_ = Boolean.valueOf(syncRaw);
> move daemon to framed transport (thrift)
> ----------------------------------------
>
> Key: CASSANDRA-241
> URL: https://issues.apache.org/jira/browse/CASSANDRA-241
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Eric Evans
> Assignee: Eric Evans
> Fix For: 0.4
>
> Attachments: 241.txt,
> v1-0001-CASSANDRA-241-optional-support-for-framed-transport.txt
>
>
> The framed transports in thrift wrap the underlying transport to prepend the
> message size as a 4 byte value. There are purported benefits to buffering,
> but the main purpose of these wrappers is to allow non-blocking servers to
> perform reads without deserialization. Of course, if the server transport is
> framed, the client's must be as well, and vice versa, (framed and non-framed
> transports are incompatible).
> CassandraDaemon is currently a threaded server with the default transport, I
> believe we should change it to being framed, for compatibility with
> non-blocking clients (this actually came up during an attempt to use a
> Twisted client).
> This will break all existing client apps, (even if fixing them is trivial).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
